Regression: team sync not accepting multiple teams #21768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Apr 23, 2021
|
|
||
| const items = ldapUserGroups.filter((field) => field && field.ou).map((field) => (typeof field.ou === 'string' ? field.ou.split(',') : field.ou)); | ||
| const groups = []; | ||
| for (const item of items) { |
Member
There was a problem hiding this comment.
this for is doing exactly what the reduce below is doing right? just flattening an array.. maybe you could use reduce in both places?
Member
There was a problem hiding this comment.
oh, just realized you used in other places too.. maybe could be even better creating a reducer to use on all those places =)
Member
There was a problem hiding this comment.
I think the Node version we use supports the [].flat function 👀 isn't it?
Member
There was a problem hiding this comment.
wut?! I didn't know that 🤔 [].flat is better indeed.. thx @KevLehman 🤗
Member
There was a problem hiding this comment.
[].flat is like the flattenDeep method of lodash, It's pretty useful 🎉
KevLehman
approved these changes
Apr 27, 2021
sampaiodiego
deleted the
regression.team-sync-not-accepting-multiple-teams
branch
Merged
vanhoang1107
pushed a commit
to vanhoang1107/Rocket.Chat
that referenced
this pull request
May 13, 2021
* rocketchat/master: (273 commits) Bump version to 3.14.0 Bump version to 3.14.0-rc.4 bump fuselage (RocketChat#21841) [FIX] Duplicated header on admin's user contextualbar (RocketChat#21810) Bump version to 3.14.0-rc.3 Bump Apps-Engine version (RocketChat#21840) [FIX][Enterprise] Omnichannel simultaneous chat limit is not properly checking the limit by department (RocketChat#21839) Fix node_modules cache path again Regression: Reactivate direct conversations only if all involved users are active (RocketChat#21714) Bump version to 3.14.0-rc.2 [FIX] Omnichannel Activity Monitor closing chats returned to the queue (RocketChat#21782) Fix node_modules cache path Regression: Problem with Importer's logs (RocketChat#21812) Chore: Add tests for teams.update REST endpoint (RocketChat#21653) QoL improvements to add channel to team flow (RocketChat#21778) Chore: Cache EE node_modules on CI (RocketChat#21831) Regression: team sync not accepting multiple teams (RocketChat#21768) regression: Italic being parsed with surrounding non-whitespace text (RocketChat#21815) Regression: Unread Threads Header and List (RocketChat#21816) Fix attachment previews. (RocketChat#21746) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments