[FIX] Wrong user in user info #21451
Conversation
dougfabris
left a comment
dougfabris
left a comment
There was a problem hiding this comment.
Remove the comments on the code and use this nice information on the PR's description.
IMHO, this information is relevant enough to be in the code. I fear someone might want to change this without the proper consideration. WDYT? I can add it to the PR also though, no problem. |
If you think it's a piece of relevant information to be there, go ahead! But remember, if you need to explain what a code does, it isn't good enough. Maybe it's not the case here! |
|
I agree! We shouldn't need to explain code, I'm all for that. But I think in specific cases it's needed, since we can't fix the "root" problem and this is a workaround. The comments don't explain the code itself, as it's pretty clear what it does. It explains why that was the choice. I'm not trying to justify the comments BTW, thats just my opinion. Maybe @ggazzo can comment about this too, since both our POVs are relevant in this case. |
…user_info * 'develop' of github.com:RocketChat/Rocket.Chat: (40 commits) [FIX] Typos/missing elements in the French translation (#21525) [FIX] Archive permissions for room moderator (#21563) [FIX] Checking 'start-discussion' Permission for MessageBox Actions (#21564) [FIX] Correcting the case there are no result in admin users list (#21556) [FIX] Don't allow whitespace on bold, italic and strike (#21483) [FIX] Message Block ordering (#21464) [IMPROVE] Add proxy for data export (#20998) [FIX] Updating a message causing URLs to be parsed even within markdown code (#21489) Bump version to 3.13.2 [FIX] Fix the bugs opening discussions (#21557) A React-based replacement for BlazeLayout (#21527) Language update from LingoHub 🤖 on 2021-04-12Z (#21530) Chore: Increase testing coverage on password policy class (#21482) Chore: Meteor update to 2.1.1 (#21494) Chore: Do not stop animations on Test Mode (#21484) Chore: Remove control character from room model operation (#21493) [NEW] New set of rules for client code (#21318) Bump version to 3.13.1 [FIX] Header component breaking if user is not part of teams room (#21465) [FIX] Admin Users list pagination (#21469) ...
Proposed changes (including videos or screenshots)
Fixed some race conditions in admin.
Self DMs used to be created with the userId duplicated. Sometimes rooms can have 2 equal uids, but it's a self DM. Fixed a getter so this isn't a problem anymore.
Issue(s)
Steps to test or reproduce
Further comments