-
Notifications
You must be signed in to change notification settings - Fork 13.1k
[NEW] New set of rules for client code #21318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
approved these changes
Apr 8, 2021
|
Great job @tassoevan and @ggazzo you guys rocks! |
gabriellsh
added a commit
that referenced
this pull request
Apr 15, 2021
…user_info * 'develop' of github.com:RocketChat/Rocket.Chat: (40 commits) [FIX] Typos/missing elements in the French translation (#21525) [FIX] Archive permissions for room moderator (#21563) [FIX] Checking 'start-discussion' Permission for MessageBox Actions (#21564) [FIX] Correcting the case there are no result in admin users list (#21556) [FIX] Don't allow whitespace on bold, italic and strike (#21483) [FIX] Message Block ordering (#21464) [IMPROVE] Add proxy for data export (#20998) [FIX] Updating a message causing URLs to be parsed even within markdown code (#21489) Bump version to 3.13.2 [FIX] Fix the bugs opening discussions (#21557) A React-based replacement for BlazeLayout (#21527) Language update from LingoHub 🤖 on 2021-04-12Z (#21530) Chore: Increase testing coverage on password policy class (#21482) Chore: Meteor update to 2.1.1 (#21494) Chore: Do not stop animations on Test Mode (#21484) Chore: Remove control character from room model operation (#21493) [NEW] New set of rules for client code (#21318) Bump version to 3.13.1 [FIX] Header component breaking if user is not part of teams room (#21465) [FIX] Admin Users list pagination (#21469) ...
Merged
|
@tassoevan @ggazzo it is a little bit unclear which versions this pull request have affected. This PR possibly broke functionality explained at #22098 (if the analysis from OP is right) but its hard to rollback to a version which is not affected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This small PR does the following:
BlazeLayoutcalls render templates inside of a React component (BlazeLayoutWrapper);FlowRouterwill be deprecated in favor of a new routing library;Reactas namespace (e.g. usememo()instead ofReact.memo());client/andee/client/directory are linted with a custom ESLint configuration that includes:react-hooks/*rules for TypeScript files;react/no-multi-comp, enforcing the rule of one single React component per module;react/display-name, which enforces that React components must have a name for debugging;import/named, avoiding broken named imports.Issue(s)
Steps to test or reproduce
Further comments
Target browser changes: