[FIX] Normalize Thread Messages

[aKn1ghtOut]

Checklist

• I have read the Contributing Guide
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Proposed changes (including videos or screenshots)

The getThreadMessages function was not using the normalize function, which adds the real names to the reactions in accordance with the Use Real Name setting. Added that. Now, the function works as expected.

Before:

Now:

Issue(s)

Closes #20841

Steps to test or reproduce

1. Set Real Names setting on for the server, or use one where it is turned on(Ex: Open.Rocket.Chat).
2. Open any thread with replies where at least one person other than the current user has reacted to a reply.
3. Hover over the reaction to look at the names.

Further comments

[sampaiodiego]

how this compares to #20634 ?

[rodrigok]

Missing the normalization on REST APIs and on getThreadsList

[KevLehman]

I think this is a duplicate of #20634

[aKn1ghtOut]

The other PR author was going about it a different way before, and perceived it to be a different issue. I think he's now implementing the changes as prescribed right now.
I'll wait for a couple days. If not, I'll implement the additions @rodrigok mentioned here instead.

[CLAassistant]

All committers have signed the CLA.

[dougfabris]

Hi there, thanks for the contribution! 🚀 💯

Closing this PR because it's stale now and it was already fixed here: #30069

---

Questions? Help needed? Feature Requests?

• Join our Open Server in the #support channel and feel free to raise a question
• Join our Community Forum and search/create a post there