Regression: Add tests to new banners REST endpoints #20492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampaiodiego
requested changes
Jan 29, 2021
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
You forgot just a .only .. but everything else looks good! :D
Co-authored-by: Diego Sampaio <[email protected]>
Contributor
Author
Sorry! That was my bad, now it's fixed. |
sampaiodiego
changed the title
sampaiodiego
approved these changes
Jan 29, 2021
Member
|
that's totally fine @lucassartor .. you did a good job, thx <3 |
Merged
vanhoang1107
pushed a commit
to vanhoang1107/Rocket.Chat
that referenced
this pull request
Feb 5, 2021
* rocketchat/master: (133 commits) Bump version to 3.11.0 Bump version to 3.11.0-rc.7 Bump version to 3.11.0-rc.6 Regression: Set image sizes based on rotation (RocketChat#20531) Regression: Apps-Engine - Convert streams to buffers on file upload (RocketChat#20523) Regression: Room not scrolling to bottom (RocketChat#20516) Regression: NPS (RocketChat#20514) Regression: Fix e2e paused state (RocketChat#20511) Regression: Custom field labels are not displayed properly on Omnichannel Contact Profile form (RocketChat#20393) Bump version to 3.11.0-rc.5 Regression: Fix banners sync data types (RocketChat#20517) Regression: Fixed update room avatar issue. (RocketChat#20433) Regression: ESLint Warning - explicit-function-return-type (RocketChat#20434) Bump version to 3.11.0-rc.4 [FIX][Apps] Don't show the "review permissions" modal when there's none to review (RocketChat#20506) Revert "[NEW][ENTERPRISE] Hide message history for new channel members (RocketChat#20253)" (RocketChat#20461) Update Apps-Engine and permissions translations (RocketChat#20491) Regression: Add tests to new banners REST endpoints (RocketChat#20492) [IMPROVE] Autofocus on directory (RocketChat#20509) Update "Industry" setting (RocketChat#20510) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Add tests for the new
banners.*endpoints:banners.getNewandbanners.dismiss.Issue(s)
Steps to test or reproduce
Further comments