Skip to content

Conversation

@sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com

This comment has been minimized.

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2021

This pull request introduces 17 alerts when merging dedfbff into 99462f0 - view on LGTM.com

new alerts:

  • 16 for Property access on null or undefined
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2021

This pull request introduces 17 alerts when merging 484195c into 0872682 - view on LGTM.com

new alerts:

  • 16 for Property access on null or undefined
  • 1 for Syntax error

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2021

This pull request introduces 17 alerts when merging 5bfc49c into c3962ec - view on LGTM.com

new alerts:

  • 16 for Property access on null or undefined
  • 1 for Syntax error

throw new Meteor.Error('error-not-allowed', 'Not allowed');
}

// TODO evaluate limit history visibility
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to implement the filter here

@sampaiodiego sampaiodiego marked this pull request as ready for review January 23, 2021 05:39
@sampaiodiego sampaiodiego merged commit 97311da into develop Jan 23, 2021
@sampaiodiego sampaiodiego deleted the db-service branch January 23, 2021 07:55
sampaiodiego added a commit that referenced this pull request Jan 28, 2021
sampaiodiego added a commit that referenced this pull request Jan 29, 2021
Co-authored-by: Gabriel Thomé <[email protected]>
Co-authored-by: Pierre Lehnen <[email protected]>
Co-authored-by: Rodrigo Nascimento <[email protected]>
vanhoang1107 pushed a commit to vanhoang1107/Rocket.Chat that referenced this pull request Feb 5, 2021
* rocketchat/master: (133 commits)
  Bump version to 3.11.0
  Bump version to 3.11.0-rc.7
  Bump version to 3.11.0-rc.6
  Regression: Set image sizes based on rotation (RocketChat#20531)
  Regression: Apps-Engine - Convert streams to buffers on file upload (RocketChat#20523)
  Regression: Room not scrolling to bottom (RocketChat#20516)
  Regression: NPS (RocketChat#20514)
  Regression: Fix e2e paused state (RocketChat#20511)
  Regression: Custom field labels are not displayed properly on Omnichannel Contact Profile form (RocketChat#20393)
  Bump version to 3.11.0-rc.5
  Regression: Fix banners sync data types (RocketChat#20517)
  Regression: Fixed update room avatar issue.  (RocketChat#20433)
  Regression: ESLint Warning - explicit-function-return-type (RocketChat#20434)
  Bump version to 3.11.0-rc.4
  [FIX][Apps] Don't show the "review permissions" modal when there's none to review (RocketChat#20506)
  Revert "[NEW][ENTERPRISE] Hide message history for new channel members (RocketChat#20253)" (RocketChat#20461)
  Update Apps-Engine and permissions translations (RocketChat#20491)
  Regression: Add tests to new banners REST endpoints (RocketChat#20492)
  [IMPROVE] Autofocus on directory (RocketChat#20509)
  Update "Industry" setting (RocketChat#20510)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants