[IMPROVE] Added auto-focus for better user-experience. #19954
Conversation
|
Can anyone help me to solve failed check? |
|
Please review! :) |
client/views/room/contextualBar/RoomMembers/List/RoomMembers.js
Outdated
Show resolved
Hide resolved
|
@Darshilp326 left few comments :) |
|
@MartinSchoeler Please review :) |
MartinSchoeler
left a comment
MartinSchoeler
left a comment
There was a problem hiding this comment.
Hey @Darshilp326 unfortunately this pull request is still not ideal, firstly because this will hardcode the autofocus on components that are used in other parts of Rocket.Chat, and this can lead to unwanted behaviors. Second, the native autofocus prop has it's limitations, so my suggestion would be to use our useAutoFocus hook for that.
I've created a pull request fixing only the directory screen, it should serve as a good example/base for the other elements that you are trying to add autofocus.
Here is the Pull Request #20509
Feel free to contact me if you have any questions about my implementation.
Looking forward to see the new changes. Thanks!
|
@MartinSchoeler Okay got your point! I will be making new changes to this pr:) |
Darshilp326
force-pushed
the
Auto-Focus
branch
from
5384a37 to
151e28b
Compare
4 participants
Proposed changes (including videos or screenshots)
Issue(s)
Closes #19378
While sending file message there is no focus on upload file modal.
While opening contexual-bar options like threads,discussions,members no focus in search bars.
Steps to test or reproduce
Untitled_.Dec.23.2020.10_57.PM.mp4
Untitled_.Dec.23.2020.11_01.PM.mp4
Further comments