Skip to content

Conversation

@aradhya-gupta
Copy link
Contributor

@aradhya-gupta aradhya-gupta commented Oct 28, 2020

Proposed changes

Closes #19378
On opening the Directory Page, the Search box is focused.

Issue(s)

#19378

How to test or reproduce

Screenshots

autoFocus

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@aradhya-gupta aradhya-gupta changed the title Auto focus input box on render [Improve] Auto focus input box on render Oct 28, 2020
@aradhya-gupta aradhya-gupta changed the title [Improve] Auto focus input box on render [IMPROVE] Auto focus input box on render Oct 28, 2020
@ankar84
Copy link

ankar84 commented Dec 8, 2020

@ggazzo please review that PR

@destro-2698
Copy link

@aradhya-gupta, when uploading the file, autofocus should be on the description, that could be handled by editing fileUpload.js and changing the onRendered method.
Could you add that to the PR too.

@MartinSchoeler
Copy link
Member

Hey @aradhya-gupta as I mentioned in this comment #19954 (review)

Simply adding the autofocus on this element is not enough, it required a little bit more work. For now let's shift the focus to this PR #19954 since he is trying to tackle more fields.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improve] Focus should be in search fields or in input text box of modal windows

4 participants