Skip to content

Regression: Rocket.Chat Apps updates always fail #19411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 3 commits into from
Oct 30, 2020
Merged

Regression: Rocket.Chat Apps updates always fail #19411

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de042ad
Fix app updates
d-gubert Oct 29, 2020
891c903
Remove handling of compiler_error in apps helper
d-gubert Oct 29, 2020
b073358
Update internationalization files
d-gubert Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions app/apps/server/communication/rest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,20 +466,27 @@ export class AppsRestApi {
return API.v1.failure({ error: 'Failed to get a file to install for the App. ' });
}

const aff = Promise.await(manager.update(buff.toString('base64')));
const aff = Promise.await(manager.update(buff));
const info = aff.getAppInfo();

// Should the updated version have compiler errors, no App will be returned
if (aff.getApp()) {
info.status = aff.getApp().getStatus();
} else {
info.status = 'compiler_error';
if (aff.hasStorageError()) {
return API.v1.failure({ status: 'storage_error', messages: [aff.getStorageError()] });
}

if (aff.hasAppUserError()) {
return API.v1.failure({
status: 'app_user_error',
messages: [aff.getAppUserError().message],
payload: { username: aff.getAppUserError().username },
});
}

info.status = aff.getApp().getStatus();

return API.v1.success({
app: info,
implemented: aff.getImplementedInferfaces(),
compilerErrors: aff.getCompilerErrors(),
licenseValidation: aff.getLicenseValidationResult(),
});
},
delete() {
Expand Down