Regression: Rocket.Chat Apps updates always fail

[d-gubert]

Proposed changes

App updates were not being handled correctly with the new APIs

Issue(s)

How to test or reproduce

Update any app

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Hotfix (a major bugfix that has to be merged asap)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

[sampaiodiego]

Should all "compile errors" be removed from the source code? like this one:

Rocket.Chat/client/admin/apps/helpers.js

Line 44 in 8217527

message = 'There has been compiler errors. App cannot be installed';

[sandrotanner]

Great, thanks!