[FIX] allow non-admin user with appropriate permissions to change channel avatars

[cprice-kgi]

allow non-admin user with appropriate permissions to change channel avatars, as expected

Proposed changes

Users who are non-admin, but still have the correct permissions in a channel to be able to change the avatar are unable to do so. The upload does not work and the avatar does not change.

This change accounts for room vs. user avatar change by using the appropriate permission check during avatar upload. Previously, a room avatar upload was attempting to use the user avatar check, which resulted in an error.

Issue(s)

Although this issue has been closed, the PR referenced does not completely resolve the issue. The PR fix only solves the formData parameter portion, which was also an issue, but the fact still remains that the channel avatar cannot be changed by non-admin users:

#18785

How to test or reproduce

Login as an owner of a channel who is not an admin user. Try to change the avatar of a channel of which you are owner. The avatar does not save.

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Hotfix (a major bugfix that has to be merged asap)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

[CLAassistant]

All committers have signed the CLA.

[sampaiodiego]

thanks @cprice-kgi for your contribution.. looks like this was already fixed by #18960 .. I'm sorry it took longer to review and merge.