[FIX] Non admin cannot add custom avatar to group

[FelipeParreira]

Proposed changes

Allow non-admins to change room avatar.

Issue(s)

#18894

How to test or reproduce

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Hotfix (a major bugfix that has to be merged asap)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Changelog

Allow non-admins to change room avatar.

Further comments

[pierre-lehnen-rc]

This change is causing avatars to not be resized even when the setting is on.

[sandrotanner]

@pierre-lehnen-rc well only if it is a room avatar. Since the option for resizing avatars is under "Accounts" it makes sense that it only applies to Accounts.

But yes, the whole avatar system should probably be cleaned out a bit. This PR would work, but it would make this part of the codebase a bit more messy.
I think the logic for weather it is a room avatar or a user avatar should happen further up.

Sadly I don't know Meteor...

On the other hand this is a hotfix for a quite important issue imho so I would very much like to see it merged in 3.7.0

[sandrotanner]

I am confused.This is in the Project https://github.com/RocketChat/Rocket.Chat/projects/54#card-45883577 but 3.7.0 has been released now and this is apparently not in it...

[klepptor]

Yes, unfortunately still not fixed in 3.7.0:

I20200929-10:57:49.543(0) Exception in setTimeout callback: TypeError: Cannot read property 'etag' of undefined at app/lib/server/functions/setRoomAvatar.js:34:46 at Meteor.EnvironmentVariable.EVp.withValue (packages/meteor.js:1234:12) at packages/meteor.js:550:25 at runWithEnvironment (packages/meteor.js:1286:24)

Wouldn't it make sense to fix already released features rather then releasing another bunch of new features every few weeks with new bugs??

[juzser]

Still happened in 3.7.1.

[sandrotanner]

Thank you @pierre-lehnen-rc!

Does anybody know when this might be in a stable release?

[sandrotanner]

Thx @sampaiodiego