Skip to content

Update the API of React Hooks using Meteor's reactive system #18226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggazzo merged 14 commits into from
Jul 11, 2020
Merged

Update the API of React Hooks using Meteor's reactive system #18226

ggazzo merged 14 commits into from
Jul 11, 2020

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 10, 2020 •
edited
Loading

Proposed changes

The useSubscription hook have been used in custom hooks that need to handle Meteor's reactivity mechanism (e.g. useReactiveValue and hooks for contexts under MeteorProvider) as it is almost prepared for the React's concurrent mode. Also, violations of the Rules of Hooks at useForm were eliminated.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan requested a review from a team July 10, 2020 22:56
@tassoevan tassoevan added area: ui Touches the code on client side type: improvement labels Jul 10, 2020
@tassoevan tassoevan added this to the 3.5.0 milestone Jul 10, 2020
@tassoevan tassoevan changed the title Refactor/hooks with reactivity Update the API of React Hooks using Meteor's reactive system Jul 10, 2020
@tassoevan tassoevan marked this pull request as ready for review July 10, 2020 23:44
@ggazzo ggazzo merged commit e4e3c3a into develop Jul 11, 2020
@ggazzo ggazzo deleted the refactor/hooks-with-reactivity branch July 11, 2020 02:10
gabriellsh added a commit that referenced this pull request Jul 13, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
47cd41b 
…reset-login

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Rewrite Contextual Bar Discussion List in React (#18127)
  Regression: Remove calls to Console API in useForm hook (#18244)
  [FIX]Update link URL at AppsWhatIsIt (#18240)
  Update the API of React Hooks using Meteor's reactive system (#18226)
  [FIX] CAS login not merging users with local accounts (#18238)
gabriellsh added a commit that referenced this pull request Jul 15, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into rewr…
2205323 
…ite/accounts

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Message actions under "unread messages" warning (#18273)
  [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260)
  [NEW] Sign in with apple (iOS client only) (#18258)
  [IMPROVE] Message action styles (#18190)
  Rewrite Contextual Bar Discussion List in React (#18127)
  Regression: Remove calls to Console API in useForm hook (#18244)
  [FIX]Update link URL at AppsWhatIsIt (#18240)
  Update the API of React Hooks using Meteor's reactive system (#18226)
  [FIX] CAS login not merging users with local accounts (#18238)
  [FIX] SAML login crashing when receiving an array of roles (#18224)
  [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)
  Update Apps-Engine version (#18212)
  [FIX] Old Data Migrations breaking upgrades (#18185)
gabriellsh added a commit that referenced this pull request Jul 15, 2020
@gabriellsh
Merge branch 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat …
4934e67 
…into rewrite/user_preferences

* 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat:
  Regression: Message actions under "unread messages" warning (#18273)
  [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260)
  [NEW] Sign in with apple (iOS client only) (#18258)
  [IMPROVE] Message action styles (#18190)
  Rewrite Contextual Bar Discussion List in React (#18127)
  Regression: Remove calls to Console API in useForm hook (#18244)
  [FIX]Update link URL at AppsWhatIsIt (#18240)
  Update the API of React Hooks using Meteor's reactive system (#18226)
  [FIX] CAS login not merging users with local accounts (#18238)
  [FIX] SAML login crashing when receiving an array of roles (#18224)
  [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222)
  Update Apps-Engine version (#18212)
  [FIX] Old Data Migrations breaking upgrades (#18185)
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees

No one assigned

Labels

area: ui Touches the code on client side type: improvement

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@tassoevan @ggazzo