Rewrite Contextual Bar Discussion List in React #18127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 8 alerts when merging fae16fe into b7e7ebe - view on LGTM.com new alerts:
|
ggazzo
force-pushed
the
rewrite/discussion
branch
from
a7403c9 to
b0afce0
Compare
tassoevan
reviewed
Jul 3, 2020
| import './DiscussionTabbar.html'; | ||
|
|
||
| const LIMIT_DEFAULT = 50; | ||
| createTemplateForComponent('DiscussionMessageList', () => import('../../../../client/Channel/Discussions/ContextualBar/List'), { |
Contributor
There was a problem hiding this comment.
Why not let this declaration in some module under /client?
ggazzo
force-pushed
the
rewrite/discussion
branch
from
6feb306 to
09c2e64
Compare
gabriellsh
previously approved these changes
Jul 10, 2020
|
This pull request introduces 2 alerts when merging 383057e into 8427e69 - view on LGTM.com new alerts:
|
ggazzo
force-pushed
the
rewrite/discussion
branch
from
8eb42ec to
3ab82ca
Compare
gabriellsh
added a commit
that referenced
this pull request
Jul 13, 2020
…reset-login * 'develop' of github.com:RocketChat/Rocket.Chat: Rewrite Contextual Bar Discussion List in React (#18127) Regression: Remove calls to Console API in useForm hook (#18244) [FIX]Update link URL at AppsWhatIsIt (#18240) Update the API of React Hooks using Meteor's reactive system (#18226) [FIX] CAS login not merging users with local accounts (#18238)
gabriellsh
added a commit
that referenced
this pull request
Jul 15, 2020
…ite/accounts * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Message actions under "unread messages" warning (#18273) [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260) [NEW] Sign in with apple (iOS client only) (#18258) [IMPROVE] Message action styles (#18190) Rewrite Contextual Bar Discussion List in React (#18127) Regression: Remove calls to Console API in useForm hook (#18244) [FIX]Update link URL at AppsWhatIsIt (#18240) Update the API of React Hooks using Meteor's reactive system (#18226) [FIX] CAS login not merging users with local accounts (#18238) [FIX] SAML login crashing when receiving an array of roles (#18224) [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222) Update Apps-Engine version (#18212) [FIX] Old Data Migrations breaking upgrades (#18185)
gabriellsh
added a commit
that referenced
this pull request
Jul 15, 2020
…into rewrite/user_preferences * 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat: Regression: Message actions under "unread messages" warning (#18273) [NEW] Added profile field to inform Nickname for users in order to be searchable (#18260) [NEW] Sign in with apple (iOS client only) (#18258) [IMPROVE] Message action styles (#18190) Rewrite Contextual Bar Discussion List in React (#18127) Regression: Remove calls to Console API in useForm hook (#18244) [FIX]Update link URL at AppsWhatIsIt (#18240) Update the API of React Hooks using Meteor's reactive system (#18226) [FIX] CAS login not merging users with local accounts (#18238) [FIX] SAML login crashing when receiving an array of roles (#18224) [FIX] Application not loading due to reverse proxy decoding API calls unnecessarily (#18222) Update Apps-Engine version (#18212) [FIX] Old Data Migrations breaking upgrades (#18185)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
More than a simple rewrite, as we're using Fuselage, our component toolkit. We introduce virtual lists and the search field.
Issue(s)
How to test or reproduce
Screenshots
before
after
Types of changes
Checklist
Changelog
Further comments