Skip to content

[FIX] Slack importer Link handling #17595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sampaiodiego merged 3 commits into from
May 19, 2020
Merged

[FIX] Slack importer Link handling #17595

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b896d1d
Fixed Link import
lpilz May 10, 2020
cdbd076
Fixed import of named URLs, since pipes get encoded as %7C we can saf…
lpilz May 13, 2020
c7b1e7d
Merge branch 'master' into importer-fix
sampaiodiego May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/importer-slack/server/importer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,8 +968,8 @@ export class SlackImporter extends Base {
message = message.replace(/:memo:/g, ':pencil:');
message = message.replace(/:piggy:/g, ':pig:');
message = message.replace(/:uk:/g, ':gb:');
message = message.replace(/<(http[s]?:[^>|]*)>/g, '$1');
message = message.replace(/<(http[s]?:[^|]*)\|([^>]*)>/g, '[$2]($1)');
message = message.replace(/<(http[s]?:[^>]*)>/g, '$1');

for (const userReplace of Array.from(this.userTags)) {
message = message.replace(userReplace.slack, userReplace.rocket);
Expand Down