[NEW] Threads V2 with improved UI and new options

[ggazzo]

closes #17945
closes #16320
closes #17362
closes #15662
closes #16986

Since we are not displaying the threads on the main thread (only if you choose, but the message is not collapsed anymore), closes #17140
closes #16281
closes #17519
closes #17083
closes #16280
closes #14869
closes #14863
closes #16230
closes #16328

Before

After

[zdumitru]

Looking at After screen and I don't think that threads panel should hover the main screen and ability to read other messages in the channel in parallel.

[engelgabriel]

@zdumitru thanks for the feedback. We are evaluating adding a button to the header so users can decide on what behavior they prefer: expended or narrow.

[lgtm-com]

This pull request introduces 2 alerts and fixes 3 when merging 9367d01 into 6c2f4ff - view on LGTM.com

new alerts:

• 1 for Useless conditional
• 1 for Useless assignment to property

fixed alerts:

• 2 for Invocation of non-function
• 1 for Superfluous trailing arguments

[lgtm-com]

This pull request fixes 3 alerts when merging 0ed366a into 6c2f4ff - view on LGTM.com

fixed alerts:

• 2 for Invocation of non-function
• 1 for Superfluous trailing arguments

[kaiiiiiiiii]

Hey guys, can we make the checkbox "Also send to channel" checked by default? My users complain that they miss messages in threads because no message is send to the main channel. Using the "Reply in Thread" already ticks the checkbox, but clicking on a previous thread message in the main room does not.

Or at least make it a configurable opton :)

Thanks

[dieg00uy]

Hey guys, can we make the checkbox "Also send to channel" checked by default? My users complain that they miss messages in threads because no message is send to the main channel. Using the "Reply in Thread" already ticks the checkbox, but clicking on a previous thread message in the main room does not.

Or at least make it a configurable opton :)

Thanks

Same here.
Please add a configurable option to this feature, we really need it on the last version (3.4.2).

Thanks!

[phlegx]

A configurable option would be awesome. I think the default on false was correct.

It would be furthermore good, to have a menu point on the lefthand side called Threads just as Slack has. In case there in an answer the Thread menu could blink or show number of messages or something. If the user clicks, all threads are opening in the main menu.

See Slack screenshot:

[danel1]

@ggazzo @sampaiodiego please take a look at the comments and offer a way to make de default-option configurable. This is really a pain for many of us how it is now.. Thanks!

[ggazzo]

@ggazzo @sampaiodiego please take a look at the comments and offer a way to make de default-option configurable. This is really a pain for many of us how it is now.. Thanks!

Try : My Account -> Preferences -> Messages -> Show thread messages in the main thread

[phlegx]

I have set this and works fine.

It would still be nice to have a Thread Menu point on the left-hand side menu, where I get notified if there are replies on a thread where I'm involved. By clicking on it, on the main chat window, all threads I'm involved could appear and I could reply there or select one for reply.

Imo the best way, you never loose overview.

[phlbrz]

@ggazzo @sampaiodiego please take a look at the comments and offer a way to make de default-option configurable. This is really a pain for many of us how it is now.. Thanks!

Try : My Account -> Preferences -> Messages -> Show thread messages in the main thread

@ggazzo @phlegx

In my instance it is already enabled, but...

To get it work in 3.5.0 I had to disable, save, enable and save again, worked as expected.

I also made a comment here: #18347 (comment)

[reetp]

@ggazzo @sampaiodiego please take a look at the comments and offer a way to make de default-option configurable. This is really a pain for many of us how it is now.. Thanks!

Try : My Account -> Preferences -> Messages -> Show thread messages in the main thread

He meant a Global option, not per user.

#18347 (comment)

Breaking changes to an established UI are not always popular - despite what designers may think - and frequently throw users, which then generates lots of ear bending, queries, and wasted time.

As has been asked many times before, please leave the default as is, and allow admins and users to change if required.

Changes like this often get missed on updates - this breaking change was only mentioned in this PR so even when reading bugs it means that it is missed and not read and understood by most admins. The first they know is they check the bug fixes, update, and the phone goes red hot.

The release notes just say

Improvements
Threads (#17416)

No mention of breaking changes?

Perhaps there should be a lot more detail in the release notes.

[phlbrz]

@ggazzo @sampaiodiego please take a look at the comments and offer a way to make de default-option configurable. This is really a pain for many of us how it is now.. Thanks!

Try : My Account -> Preferences -> Messages -> Show thread messages in the main thread

He meant a Global option, not per user.

#18347 (comment)

Breaking changes to an established UI are not always popular - despite what designers may think - and frequently throw users, which then generates lots of ear bending, queries, and wasted time.

As has been asked many times before, please leave the default as is, and allow admins and users to change if required.

Changes like this often get missed on updates - this breaking change was only mentioned in this PR so even when reading bugs it means that it is missed and not read and understood by most admins. The first they know is they check the bug fixes, update, and the phone goes red hot.

The release notes just say

Improvements
Threads (#17416)

No mention of breaking changes?

Perhaps there should be a lot more detail in the release notes.

Yes, sorry, I forgot to say that.

I had to do in Administration -> Accounts -> Default User Preferences -> Show thread messages in the main thread

If enabled, then disable and save. Enable and save again.

I've updated my answer.

Thank's.

[reetp]

I had to do in Administration -> Accounts -> Default User Preferences -> Show thread messages in the main thread

Nope. Tried that.

On 3.5.4 I have tried to change the global default but it seems to make absolutely no difference to users so when they reply to a thread and their default is Off it appears to override the global default.

So if I post a comment and the user replying has it set to Off then it sets the whole thread as off, so users then have to remember to tick the box (even me with User pref set on). Which they usually do not do - they don't even realise despite being told.

Even though my setting is On I have to remember to then check the "Send to Channel" box myself. That can't be right can it?

And as a result we have a lot of confused and angry users. Including me.

How do we change every users default back to On?

Anyone know the setting in the DB that I can manually change before I get stabbed?

[reetp]

Hmmm.

It gets set in:

db.getCollection('users')

"settings" : {
    "preferences" : {
        "showMessageInMainThread" : true

No idea how to update them all to the new default quickly though. And no idea what happens by default to new users either?

Going to be a long night doing it manually. Grrrrrrr.

[ggazzo]

hey @reetp sorry for the delay, but I think you got (or I explained) it wrong... the personal setting and the checkbox are different things... the personal setting was designed to allow users to keep the old thread experience (keeping all the messages in the main thread)... the second one, is for the new design which omits the ordinary conversations from the main thread, and you choose if you want to send in the main channel if it's so important... actually we have plans to remove the personal setting and hide the ordinary messages from the main thread (its an option to give more time to users get used with the new style)...

[zdumitru]

@ggazzo Global setting to not send thread replies to the channel doesn't work. Even when personal setting is set to the same. I think that what @reetp was trying to say. And I confirm that we also have similar issue.