Skip to content

Conversation

@ashwaniYDV
Copy link
Contributor

@ashwaniYDV ashwaniYDV commented Jan 19, 2020

Closes #16280

After Changes:

Whether you are in any part of messags in a the thread. When message is sent, it brings the user back to the sent message. This also ensures the user if sent markdown message is correctly rendered.

azazaaz

@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2020

This pull request introduces 1 alert when merging db5ad15 into f92cff7 - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

@ashwaniYDV
Copy link
Contributor Author

ashwaniYDV commented Jan 19, 2020

@ggazzo I dont know why I'm getting this alert from the bot. It is mentioning your commit f92cff7

@ashwaniYDV ashwaniYDV requested a review from ggazzo January 20, 2020 20:09
@ashwaniYDV ashwaniYDV changed the title [FIX] In threads sending a message should scroll to latest thread message [FIX] In threads sending a message should scroll to the sent message Jan 20, 2020
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@lgtm-com
Copy link

lgtm-com bot commented Mar 19, 2020

This pull request introduces 1 alert when merging 8432b6f into 77472fd - view on LGTM.com

new alerts:

  • 1 for Expression has no effect

@zdumitru
Copy link
Contributor

zdumitru commented Mar 19, 2020

@ggazzo Code review, please.

@ggazzo
Copy link
Member

ggazzo commented Apr 13, 2020

@ashwaniYDV could you check how we are using resize observer on room.js and apply the same behavior? thanks :)

@ggazzo ggazzo added this to the 3.2.0 milestone Apr 13, 2020
@ggazzo ggazzo modified the milestones: 3.2.0, 4.0.0 Apr 27, 2020
@engelgabriel engelgabriel modified the milestones: 4.0.0, 3.4.0 May 21, 2020
@rodrigok
Copy link
Member

@ggazzo should we close this one in favor of the new implementation?

@ashwaniYDV ashwaniYDV closed this Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In threads sending a message should scroll to latest thread message

6 participants