[FIX] Emoji are rendered in URL #15516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
requested changes
Oct 8, 2019
Member
ggazzo
left a comment
ggazzo
left a comment
There was a problem hiding this comment.
hey @oguhpereira thanks for your contribution, but your change "skips" the others parsers (like mentions or emojis).
The method we developed to solve this is using tokens
use the replaceFn argument Autolinker.link(msgPart, {replaceFn ....}, to return a token instead of the original html AND insert on message.tokens like:
message.tokens.push({ token, text: tag.toAnchorString() })look how we protect the code parse here app/markdown/lib/parser/original/code.js
app/autolinker/client/client.js
Outdated
| msgParts = message.html.split(regexTokens); | ||
| } else { | ||
| msgParts = [message.html]; | ||
| msgParts = [message.msg]; |
Member
There was a problem hiding this comment.
Suggested change
| msgParts = [message.msg]; | |
| msgParts = [message.html]; |
Contributor
Author
There was a problem hiding this comment.
Thank's for feedback @ggazzo,
I had not realized, sorry. I rollback my changes and added your changes in my commit
ggazzo
approved these changes
Oct 9, 2019
This was referenced Oct 9, 2019
Closed
|
Will this merge affect this issue? #7741 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15050
Closes #6770
Closes #12321