Skip to content

[Fix] Links containing ":" will not be rendered as emoji #13604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
knrt10 wants to merge 1 commit into from
Closed

[Fix] Links containing ":" will not be rendered as emoji #13604

knrt10 wants to merge 1 commit into from

Conversation

@knrt10
Copy link
Contributor

@knrt10 knrt10 commented Mar 3, 2019 •
edited
Loading

Closes #12321 & #6770

Steps to solve:-

To avoid this, HTML messages were split into an array. The array was looped and matched with URL RegEx. Only those were changed which did not match URL RegEx.

Screenshot

screenshot 2019-03-03 at 4 21 51 pm

@tassoevan would you please review

@tassoevan tassoevan requested review from ggazzo and tassoevan March 4, 2019 01:15
@knrt10
Copy link
Contributor Author

knrt10 commented May 13, 2019

@tassoevan can you please check this

@ggazzo
Copy link
Member

ggazzo commented Oct 9, 2019

hey @knrt10 thanks for your time, but I believe that code (#15516) are the best way to avoid emojis inside urls

@ggazzo ggazzo closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tassoevan tassoevan Awaiting requested review from tassoevan

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees

No one assigned

Labels

feat: message subj: message rendering type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Links containing ":" (e.g. LinkedIn links) will render emojis

3 participants

@knrt10 @ggazzo @tassoevan