Skip to content

refactor(RoomView): unblock compiler for ReactionPicker #7633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 1 commit into from
Sep 2, 2026
+6 −8
Merged

refactor(RoomView): unblock compiler for ReactionPicker #7633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/views/RoomView/components/ReactionPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@ const ReactionPicker = ({ onEmojiSelected, messageId, reactionClose }: IReaction
const [searchedEmojis, setSearchedEmojis] = useState<IEmoji[]>([]);
const [searching, setSearching] = useState<boolean>(false);

const handleTextChange = useDebounce((text: string) => {
setSearching(text !== '');
handleSearchEmojis(text);
}, textInputDebounceTime);

const handleSearchEmojis = async (text: string) => {
logEvent(events.REACTION_PICKER_SEARCH_EMOJIS);
const emojis = await searchEmojis(text);
setSearchedEmojis(emojis);
};

const handleTextChange = useDebounce((text: string) => {
setSearching(text !== '');
handleSearchEmojis(text);
}, textInputDebounceTime);

const handleEmojiSelect = (_eventType: EventTypes, emoji?: IEmoji) => {
logEvent(events.REACTION_PICKER_EMOJI_SELECTED);
if (messageId && emoji) {
Expand Down
4 changes: 1 addition & 3 deletions app/views/RoomView/reactCompilerContract.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ const EXTRA_FILES: string[] = [
// Files the React Compiler silently skips today. Fixing the underlying cause must remove its file from this list.
const KNOWN_SKIPPED: string[] = [
// Disables a React ESLint rule, which makes the compiler bail out.
'app/views/RoomView/List/hooks/useMessages.ts',
// Reads a variable before its declaration.
'app/views/RoomView/components/ReactionPicker.tsx'
'app/views/RoomView/List/hooks/useMessages.ts'
];

const collectSourceFiles = (dir: string): string[] => {
Expand Down
Loading