refactor(RoomView): unblock compiler for ReactionPicker - #7633
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
WalkthroughThe change reorders two ChangesReactionPicker compiler support
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested labels: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
diegolmello
had a problem deploying
to
approve_e2e_testing
September 2, 2026 17:24 — with
GitHub Actions
Error
diegolmello
had a problem deploying
to
ios_build
September 2, 2026 17:26 — with
GitHub Actions
Error
diegolmello
had a problem deploying
to
android_build
September 2, 2026 17:26 — with
GitHub Actions
Error
diegolmello
force-pushed
the
native-34-roomview-hooks-2
branch
from
September 2, 2026 17:29
7b3760c to
d5083d6
Compare
diegolmello
requested a deployment
to
approve_e2e_testing
September 2, 2026 17:30 — with
GitHub Actions
Waiting
diegolmello
marked this pull request as ready for review
September 2, 2026 17:31
diegolmello
requested a deployment
to
ios_build
September 2, 2026 17:32 — with
GitHub Actions
Waiting
diegolmello
requested a deployment
to
android_build
September 2, 2026 17:32 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Moves the Emoji search function above the debounced text-change function so the React Compiler can compile ReactionPicker instead of silently skipping it.
This is a declaration-order change. Reaction search behavior is unchanged.
Issue(s)
https://rocketchat.atlassian.net/browse/NATIVE-34
Stacked on #7482.
How to test or reproduce
Screenshots
Not applicable.
Types of changes
Checklist
Further comments
This draft targets the head branch of #7482 so the review contains only the ReactionPicker compiler change.
Summary by CodeRabbit