Skip to content

refactor(RoomView): unblock compiler for ReactionPicker - #7633

Merged
diegolmello merged 1 commit into
native-34-roomview-hooksfrom
native-34-roomview-hooks-2
Sep 2, 2026
Merged

refactor(RoomView): unblock compiler for ReactionPicker#7633
diegolmello merged 1 commit into
native-34-roomview-hooksfrom
native-34-roomview-hooks-2

Conversation

@diegolmello

@diegolmello diegolmello commented Sep 2, 2026

Copy link
Copy Markdown
Member

Proposed changes

Moves the Emoji search function above the debounced text-change function so the React Compiler can compile ReactionPicker instead of silently skipping it.

This is a declaration-order change. Reaction search behavior is unchanged.

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-34

Stacked on #7482.

How to test or reproduce

  1. Open a Room.
  2. Open the Reaction picker for a Message.
  3. Search for an Emoji.
  4. Confirm that matching Emoji results appear.
  5. Run the RoomView React Compiler contract and confirm ReactionPicker compiles.

Screenshots

Not applicable.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (not applicable)
  • Any dependent changes have been merged and published in downstream modules (not applicable)

Further comments

This draft targets the head branch of #7482 so the review contains only the ReactionPicker compiler change.

Summary by CodeRabbit

  • Refactor
    • Reordered internal reaction picker declarations without changing functionality.
  • Tests
    • Updated compiler validation coverage to include the reaction picker component.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: fce685a4-24c9-4f63-b02d-f5af34ffaf30

📥 Commits

Reviewing files that changed from the base of the PR and between 99f9760 and d5083d6.

📒 Files selected for processing (2)
  • app/views/RoomView/components/ReactionPicker.tsx
  • app/views/RoomView/reactCompilerContract.test.ts

Walkthrough

The change reorders two ReactionPicker handler declarations and removes ReactionPicker.tsx from the React Compiler skip list.

Changes

ReactionPicker compiler support

Layer / File(s) Summary
Handler order and compiler contract
app/views/RoomView/components/ReactionPicker.tsx, app/views/RoomView/reactCompilerContract.test.ts
The handler declarations are reordered without behavior changes. The compiler contract now compiles ReactionPicker.tsx normally.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: type: chore


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@diegolmello
diegolmello force-pushed the native-34-roomview-hooks-2 branch from 7b3760c to d5083d6 Compare September 2, 2026 17:29
@diegolmello diegolmello changed the title fix(RoomView): keep latest emoji search results refactor(RoomView): unblock compiler for ReactionPicker Sep 2, 2026
@diegolmello
diegolmello marked this pull request as ready for review September 2, 2026 17:31
@diegolmello
diegolmello merged commit be5b0b0 into native-34-roomview-hooks Sep 2, 2026
6 of 8 checks passed
@diegolmello
diegolmello deleted the native-34-roomview-hooks-2 branch September 2, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant