Repository navigation
fix: allow retrying/deleting stuck (TEMP) messages #7560
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -165,4 +165,3 @@ class NotificationIntentHandler { | |
| } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| jest.mock('expo-av', () => { | ||
| const Audio = { | ||
| playAsync: jest.fn(), | ||
| stopAsync: jest.fn(), | ||
| unloadAsync: jest.fn(), | ||
| setIsLoopingAsync: jest.fn(), | ||
| setPositionAsync: jest.fn(), | ||
| setVolumeAsync: jest.fn(), | ||
| getStatusAsync: jest.fn(() => Promise.resolve({})), | ||
| AndroidOutputFormat: { AAC_ADTS: 0, MPEG_4: 1, THREE_GPP: 2 }, | ||
| AndroidAudioEncoder: { AAC: 0, AMR_NB: 1 }, | ||
| IOSOutputFormat: { MPEG4AAC: 0 }, | ||
| IOSAudioEncoder: { AAC: 0 }, | ||
| IOSAudioQuality: { LOW: 0, MEDIUM: 1, HIGH: 2 }, | ||
| RecordingOptionsPresets: { | ||
| LOW_QUALITY: { | ||
| android: { sampleRate: 8000, numberOfChannels: 1, bitRate: 128000 }, | ||
| ios: { sampleRate: 8000, numberOfChannels: 1, bitRate: 128000 } | ||
| }, | ||
| HIGH_QUALITY: { | ||
| android: { sampleRate: 44100, numberOfChannels: 2, bitRate: 256000 }, | ||
| ios: { sampleRate: 44100, numberOfChannels: 2, bitRate: 256000 } | ||
| } | ||
| } | ||
| }; | ||
| return { | ||
| Audio, | ||
| Sound: class { | ||
| loadAsync = jest.fn(); | ||
| playAsync = jest.fn(); | ||
| unloadAsync = jest.fn(); | ||
| }, | ||
| InterruptionModeIOS: { MixWithOthers: 0, DoNotMix: 1 }, | ||
| InterruptionModeAndroid: { MixWithOthers: 0, DoNotMix: 1 }, | ||
| requestPermissionsAsync: jest.fn(() => Promise.resolve({ status: 'granted', granted: true, canAskAgain: true })), | ||
| getPermissionsAsync: jest.fn(() => Promise.resolve({ status: 'granted', granted: true, canAskAgain: true })) | ||
| }; | ||
| }); | ||
|
|
||
| import { MessageContainer } from './index'; | ||
| import { messagesStatus } from '../../lib/constants/messagesStatus'; | ||
|
Comment on lines
+40
to
+41
Contributor
There was a problem hiding this comment. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo "== files =="
git ls-files | rg '(^|/)app/containers/message/index.test.tsx$|(^|/)package.json$|(^|/).oxlintrc.json$|jest|babel|metro|babel.config'
echo "== test file outline/lines =="
if [ -f app/containers/message/index.test.tsx ]; then
wc -l app/containers/message/index.test.tsx
sed -n '1,120p' app/containers/message/index.test.tsx | cat -n
fi
echo "== oxlint config =="
if [ -f .oxlintrc.json ]; then
cat -n .oxlintrc.json
fi
echo "== relevant transform/mocking files =="
for f in \
package.json \
metro.config.js \
babel.config.js \
babel.config.ts \
.babelrc \
jest.config.js \
jest.config.ts \
app.config.js \
app.config.ts; do
if [ -f "$f" ]; then
echo "-- $f --"
sed -n '1,220p' "$f" | cat -n
fi
done
echo "== expo-av mock references =="
rg -n "expo-av|Audio|Sound|messagesStatus|jest.mock\\(" . --glob '!node_modules' --glob '!dist' --glob '!build' | head -200Repository: RocketChat/Rocket.Chat.ReactNative Length of output: 33238 🌐 Web query:
💡 Result: The ESLint rule Citations:
Move the imports before
🧰 Tools🪛 ESLint[error] 40-40: Import in body of module; reorder to top. (import/first) [error] 41-41: Import in body of module; reorder to top. (import/first) 🤖 Prompt for AI AgentsSources: Coding guidelines, Linters/SAST tools |
||
|
|
||
| const makeMessage = (status: number) => | ||
| ({ | ||
| _id: 'msg1', | ||
| id: 'msg1', | ||
| rid: 'rid1', | ||
| msg: 'hello', | ||
| u: { _id: 'u1', username: 'user', name: 'User' }, | ||
| ts: 0, | ||
| status | ||
| } as any); | ||
|
|
||
| describe('Message.hasError', () => { | ||
| it('is true for ERROR status messages (retry/delete available)', () => { | ||
| const wrapper = new MessageContainer({ item: makeMessage(messagesStatus.ERROR) } as any); | ||
| expect(wrapper.hasError).toBe(true); | ||
| }); | ||
|
|
||
| it('is true for TEMP (stuck sending) status messages so they can be retried/deleted', () => { | ||
| const wrapper = new MessageContainer({ item: makeMessage(messagesStatus.TEMP) } as any); | ||
| expect(wrapper.hasError).toBe(true); | ||
| }); | ||
|
|
||
| it('is false for a successfully SENT message', () => { | ||
| const wrapper = new MessageContainer({ item: makeMessage(messagesStatus.SENT) } as any); | ||
| expect(wrapper.hasError).toBe(false); | ||
| }); | ||
| }); | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: RocketChat/Rocket.Chat.ReactNative
Length of output: 6576
🏁 Script executed:
Repository: RocketChat/Rocket.Chat.ReactNative
Length of output: 10983
Keep the media-action dismissal delay Android-specific.
ActionsButtonis rendered from shared MessageComposer UI, so the unconditional 550 ms delays also run on iOS. Preserve the original 250 ms behavior on non-Android platforms and define a shared platform-specific delay constant for the three media callbacks.🤖 Prompt for AI Agents