Skip to content

[Fix] first's handling of import = require - #1963

Merged
ljharb merged 1 commit into
import-js:masterfrom
MatthiasKunnen:issue-1957-first-import-require
Jan 23, 2021
Merged

[Fix] first's handling of import = require#1963
ljharb merged 1 commit into
import-js:masterfrom
MatthiasKunnen:issue-1957-first-import-require

Conversation

@MatthiasKunnen

Copy link
Copy Markdown
Contributor

The rule now handles TSImportEqualsDeclaration.

This closes #1957.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-2.6%) to 95.355% when pulling 277c86f on MatthiasKunnen:issue-1957-first-import-require into 8c1a65d on benmosher:master.

@coveralls

coveralls commented Dec 10, 2020

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.0009%) to 97.987% when pulling 196d655 on MatthiasKunnen:issue-1957-first-import-require into 6bb8528 on benmosher:master.

@ljharb
ljharb force-pushed the issue-1957-first-import-require branch from 277c86f to 196d655 Compare January 23, 2021 15:30

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks. Rebased.

@ljharb
ljharb merged commit 196d655 into import-js:master Jan 23, 2021
@Peeja

Peeja commented Jan 24, 2021

Copy link
Copy Markdown

How timely, I just hit this! Thank you, @MatthiasKunnen! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[first] doesn't recognize "import = require" imports in TypeScript

4 participants