fix(voip): enable DM nav for users with SIP extension

[diegolmello]

Proposed changes

A Rocket.Chat user can have both a DM and a sipExtension. The existing guards treat any truthy sipExtension as "no DM exists", which wrongly disables the Message button on CallView and the header-content tap target, and also prevents the incoming-call flow from resolving roomId for that user. Pure SIP-only peers (no RC username, hence no DM) remain correctly gated by roomId == null.

• MediaSessionInstance.resolveRoomIdFromContact — no longer early-returns when sipExtension is present; the existing !username short-circuit already covers SIP-only peers.
• navigateToCallRoom — drops the sipExtension guard; !roomId and !username are sufficient.
• CallButtons.messageDisabled → roomId == null.
• MediaCallHeader/components/Content.contentDisabled → roomId == null.

Flipped tests: "no-op for SIP contact" / "skips DM lookup for SIP" → now expect DM resolution and navigation when the contact has both username and sipExtension.

Issue(s)

https://rocketchat.atlassian.net/browse/VMUX-95

How to test or reproduce

Place a call to (or receive one from) a Rocket.Chat user whose profile has a sipExtension set. Before: Message button + header title row appear disabled. After: both are enabled and tapping them navigates to the DM for that user. Pure SIP-dialed peers (no RC user) still disable Message and header navigation.

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

• Bug Fixes
  • SIP contacts with associated usernames now properly resolve to their direct message rooms, enabling navigation during active calls
  • Messaging functionality is now available during calls with SIP contacts that have usernames
  • Fixed room lookup behavior for SIP-based contacts

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• app/views/CallView/__snapshots__/index.test.tsx.snap is excluded by !**/*.snap

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9bf5a1d0-3ab6-4eb6-b14e-e60a98894195

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

The changes enable VoIP room resolution and navigation for SIP contacts that have both a username and sipExtension, removing previous logic that treated such contacts as peer-only and disabled room lookup and messaging features.

Changes

Cohort / File(s)	Summary
MediaCallHeader app/containers/MediaCallHeader/MediaCallHeader.test.tsx, app/containers/MediaCallHeader/components/Content.tsx	Test assertion updated to expect navigation when contact has both username and sipExtension. Content component's disable logic changed to exclude sipExtension check, now only disables when roomId is absent.
MediaSessionInstance app/lib/services/voip/MediaSessionInstance.test.ts, app/lib/services/voip/MediaSessionInstance.ts	Early return condition relaxed to only exit when contact is absent. Tests updated to expect DM subscription lookup for contacts with both username and sipExtension, replacing prior assertions that skipped lookup.
navigateToCallRoom app/lib/services/voip/navigateToCallRoom.test.ts, app/lib/services/voip/navigateToCallRoom.ts	Function no longer skips navigation for contacts with sipExtension; now only returns early when roomId or username is missing. Test case updated to assert navigation occurs for SIP contacts with both username and extension.
CallButtons app/views/CallView/components/CallButtons.tsx	Removed contact dependency from store. Message disable logic changed to only check roomId, no longer disabling when sipExtension is present.

Sequence Diagram

sequenceDiagram
    actor User
    participant Content as Content Component
    participant MediaSession as MediaSessionInstance
    participant DM as DM Subscription Service
    participant Navigation as Navigation Service
    
    User->>Content: Press call button (SIP contact with username & extension)
    Content->>MediaSession: initiateCall() with contact
    MediaSession->>MediaSession: resolveRoomIdFromContact()
    MediaSession->>DM: getDMSubscriptionByUsername(contact.username)
    DM-->>MediaSession: { rid: 'dm-ext' }
    MediaSession->>MediaSession: setRoomId('dm-ext')
    MediaSession-->>Content: roomId resolved
    Content->>Navigation: navigateToCallRoom({ isMasterDetail: true })
    Navigation->>Navigation: Lookup room by roomId
    Navigation-->>User: Navigate to call room

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Suggested labels

type: bug

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main fix: enabling DM navigation for users who have both a SIP extension and a Rocket.Chat username, which is the core intent of all changes across test files and components.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}