test(voip): tighten ringing endCall assertion and add VideoConf VoIP-lock saga coverage

[diegolmello]

Proposed changes

Strengthens the VoIP integration and saga test suites without touching production code.

app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx

• Tightens the ringing-state MediaSessionInstance.endCall case so it now asserts call.reject was invoked and call.hangup was not, matching the ringing-vs-active branching inside MediaSessionInstance.endCall. Existing RNCallKeep.endCall and useCallStore assertions are preserved.
• Documents that @rocket.chat/media-signaling is fully mocked at the SDK boundary, so these tests exercise signaling orchestration, Zustand state and navigation — not real WebRTC (peer connections, ICE, media tracks). Regressions in the real WebRTC stack still require device or E2E coverage.

app/sagas/__tests__/videoConf.voipBlock.test.ts (new)

Covers the interaction between VoIP and incoming direct videoconf rings:

• When voipBlocksIncomingVideoconf() returns true, an incoming videoconf call websocket message is short-circuited at onDirectCall and state.videoConf.calls is left unchanged (same array reference, length 0).
• When it returns false, the saga adds the expected call to state.videoConf.calls with callId, uid, rid and action: 'call'.
• Dispatches use the same envelope shape that the production DDP handler emits into handleVideoConfIncomingWebsocketMessages, so the test exercises the real action → saga → reducer path end-to-end.
• beforeEach resets the VoIP guard mock between cases.

Issue(s)

How to test or reproduce

TZ=UTC yarn test --testPathPattern='VoipCallLifecycle.integration|videoConf.voipBlock'

Screenshots

N/A (tests only)

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Documentation update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Further comments

• Test-only change; no production behavior is modified.
• The negative assertion (hangup not called on ringing) guards against an accidental swap of the reject/hangup branches in MediaSessionInstance.endCall.
• The new saga test uses the real reducer graph and root saga so the VoIP guard, action payload shape and reducer storage stay in sync end-to-end.

[coderabbitai]

Walkthrough

Clarifies mocking scope and refines assertions in a VoIP call lifecycle integration test; adds a new Jest test file validating videoConf root saga behavior for incoming "direct videoconf" websocket messages covering both blocked and allowed call scenarios.

Changes

Cohort / File(s)	Summary
VoIP lifecycle integration test app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx	Clarified that @rocket.chat/media-signaling and the WebRTC stack are mocked at the Jest boundary; renamed the "B3" test to cover "reject (not hangup) + RNCallKeep cleanup", removed explicit state: 'ringing' in call creation, and added assertions that ringingCall.reject is called while ringingCall.hangup is not.
Videoconf saga tests (new) app/sagas/__tests__/videoConf.voipBlock.test.ts	Added tests for videoConfRootSaga handling incoming websocket call envelopes. Mocks voipBlocksIncomingVideoconf, runs saga with a test store, and verifies behavior when the block returns true (call blocked, no calls added) and when it returns false (call allowed, one call entry added with matching callId, uid, rid, and action).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested labels

type: test

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title concisely captures the two main changes: tightening ringing endCall assertion and adding VideoConf VoIP-lock saga coverage, directly reflecting the core test modifications in both modified and new test files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (2)

app/sagas/__tests__/videoConf.voipBlock.test.ts (2)

1-3: Nit: redundant default in the mock factory.

The factory sets voipBlocksIncomingVideoconf to jest.fn(() => false), and beforeEach also calls mockReset() + mockReturnValue(false). Since mockReset wipes the factory implementation, the initial () => false never actually takes effect after the first test runs. Consider using plain jest.fn() in the factory to make it explicit that beforeEach owns the default.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/sagas/__tests__/videoConf.voipBlock.test.ts` around lines 1 - 3, The mock
factory currently sets voipBlocksIncomingVideoconf to jest.fn(() => false) even
though your beforeEach calls mockReset() and mockReturnValue(false), so the
initial default is redundant; change the factory to export
voipBlocksIncomingVideoconf as plain jest.fn() and rely on the test-suite
beforeEach to set/reset the default mockReturnValue(false) via
mockReset()/mockReturnValue to make ownership of the default explicit.

---

38-41: Minor: the tuple destructure is a no-op.

const [wsAction, wsParams] = [envelope, undefined] unpacks a literal pair created on the same line, so wsAction === envelope and wsParams === undefined unconditionally. If the goal is only to mirror the rooms.ts → handleVideoConfIncomingWebsocketMessages call shape for readers, a single-line dispatch with an inline comment would be clearer:

♻️ Proposed simplification

 function dispatchIncomingCallLikeRooms(store: ReturnType<typeof setupStoreWithVideoConfSaga>): void {
-	const [wsAction, wsParams] = [envelope, undefined] as const;
-	store.dispatch(handleVideoConfIncomingWebsocketMessages({ action: wsAction, params: wsParams }));
+	// Mirrors rooms.ts: envelope is passed as `action`, `params` is undefined on the outer payload.
+	store.dispatch(handleVideoConfIncomingWebsocketMessages({ action: envelope, params: undefined }));
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/sagas/__tests__/videoConf.voipBlock.test.ts` around lines 38 - 41, The
tuple destructure in dispatchIncomingCallLikeRooms is a no-op; replace the
two-line const unpack with a single-line dispatch that directly passes the
expected shape to handleVideoConfIncomingWebsocketMessages (e.g.,
store.dispatch(handleVideoConfIncomingWebsocketMessages({ action: envelope,
params: undefined }))), keeping the function name dispatchIncomingCallLikeRooms
and the referenced envelope and setupStoreWithVideoConfSaga symbols intact and
optionally add an inline comment that this mirrors rooms.ts call shape for
clarity.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@app/sagas/__tests__/videoConf.voipBlock.test.ts`:
- Around line 1-3: The mock factory currently sets voipBlocksIncomingVideoconf
to jest.fn(() => false) even though your beforeEach calls mockReset() and
mockReturnValue(false), so the initial default is redundant; change the factory
to export voipBlocksIncomingVideoconf as plain jest.fn() and rely on the
test-suite beforeEach to set/reset the default mockReturnValue(false) via
mockReset()/mockReturnValue to make ownership of the default explicit.
- Around line 38-41: The tuple destructure in dispatchIncomingCallLikeRooms is a
no-op; replace the two-line const unpack with a single-line dispatch that
directly passes the expected shape to handleVideoConfIncomingWebsocketMessages
(e.g., store.dispatch(handleVideoConfIncomingWebsocketMessages({ action:
envelope, params: undefined }))), keeping the function name
dispatchIncomingCallLikeRooms and the referenced envelope and
setupStoreWithVideoConfSaga symbols intact and optionally add an inline comment
that this mirrors rooms.ts call shape for clarity.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ccd3049b-5fb9-407b-9701-9cb1022e8d64

📥 Commits

Reviewing files that changed from the base of the PR and between 9c84d4c and 037c1c5.

📒 Files selected for processing (2)

• app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx
• app/sagas/__tests__/videoConf.voipBlock.test.ts

📜 Review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: ESLint and Test / run-eslint-and-test

🧰 Additional context used

📓 Path-based instructions (6)

**/*.{js,jsx,ts,tsx,json}

📄 CodeRabbit inference engine (CLAUDE.md)

Configure Prettier with tabs, single quotes, 130 character width, no trailing commas, arrow parens avoid, and bracket same line

Files:

• app/sagas/__tests__/videoConf.voipBlock.test.ts
• app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Use ESLint with @rocket.chat/eslint-config base configuration including React, React Native, TypeScript, and Jest plugins

Files:

• app/sagas/__tests__/videoConf.voipBlock.test.ts
• app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Use TypeScript with strict mode enabled and configure baseUrl to app/ for import resolution

**/*.{ts,tsx}: Use TypeScript for type safety; add explicit type annotations to function parameters and return types
Prefer interfaces over type aliases for defining object shapes in TypeScript
Use enums for sets of related constants rather than magic strings or numbers

Files:

• app/sagas/__tests__/videoConf.voipBlock.test.ts
• app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx

app/sagas/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Place Redux sagas in app/sagas/ directory with separate files for init, login, rooms, messages, encryption, deepLinking, and videoConf side effects

Files:

• app/sagas/__tests__/videoConf.voipBlock.test.ts

**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

**/*.{js,ts,jsx,tsx}: Use descriptive names for functions, variables, and classes that clearly convey their purpose
Write comments that explain the 'why' behind code decisions, not the 'what'
Keep functions small and focused on a single responsibility
Use const by default, let when reassignment is needed, and avoid var
Prefer async/await over .then() chains for handling asynchronous operations
Use explicit error handling with try/catch blocks for async operations
Avoid deeply nested code; refactor complex logic into helper functions

Files:

• app/sagas/__tests__/videoConf.voipBlock.test.ts
• app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx

app/containers/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Place reusable UI components in app/containers/ directory

Files:

• app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx

🧠 Learnings (5)

📓 Common learnings

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to app/lib/services/voip/**/*.{ts,tsx} : Implement VoIP with WebRTC peer-to-peer audio calls in app/lib/services/voip/ using Zustand stores instead of Redux, with native CallKit (iOS) and Telecom (Android) integration; keep VoIP and VideoConf separate

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to @(app/sagas/videoConf.ts|app/lib/methods/videoConf.ts) : Manage video conferencing via Redux actions/reducers/sagas in app/sagas/videoConf.ts and app/lib/methods/videoConf.ts using server-managed Jitsi integration; do not conflate with VoIP

📚 Learning: 2026-04-07T17:49:17.538Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to @(app/sagas/videoConf.ts|app/lib/methods/videoConf.ts) : Manage video conferencing via Redux actions/reducers/sagas in app/sagas/videoConf.ts and app/lib/methods/videoConf.ts using server-managed Jitsi integration; do not conflate with VoIP

Applied to files:

• app/sagas/__tests__/videoConf.voipBlock.test.ts
• app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx

📚 Learning: 2026-04-07T17:49:17.538Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to app/lib/services/voip/**/*.{ts,tsx} : Implement VoIP with WebRTC peer-to-peer audio calls in app/lib/services/voip/ using Zustand stores instead of Redux, with native CallKit (iOS) and Telecom (Android) integration; keep VoIP and VideoConf separate

Applied to files:

• app/sagas/__tests__/videoConf.voipBlock.test.ts
• app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx

📚 Learning: 2026-04-07T17:49:17.538Z

Learnt from: CR
Repo: RocketChat/Rocket.Chat.ReactNative PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-04-07T17:49:17.538Z
Learning: Applies to app/sagas/**/*.{ts,tsx} : Place Redux sagas in app/sagas/ directory with separate files for init, login, rooms, messages, encryption, deepLinking, and videoConf side effects

Applied to files:

• app/sagas/__tests__/videoConf.voipBlock.test.ts

📚 Learning: 2026-03-30T15:49:30.957Z

Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6875
File: app/containers/RoomItem/Actions.tsx:12-12
Timestamp: 2026-03-30T15:49:30.957Z
Learning: In RocketChat/Rocket.Chat.ReactNative, `react-native-worklets` version 0.6.1 does NOT export a built-in Jest mock (e.g., no `react-native-worklets/lib/module/mock`). The correct Jest mock approach for this version is to add a manual mock in `jest.setup.js`: `jest.mock('react-native-worklets', () => ({ scheduleOnRN: jest.fn((fn, ...args) => fn(...args)) }))`.

Applied to files:

• app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx

🔇 Additional comments (1)

app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx (1)

655-668: B3 assertions look correct.

The updated test properly covers the reject-vs-hangup branch for ringing calls, and the default state: 'ringing' in makeCall keeps the setup aligned with the scenario.