Repository navigation
chore: migrate from expo-av to expo-audio and expo-video #6719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 250 commits
Commits
Show all changes
306 commits
Select commit
Hold shift + click to select a range
acd8675
Merge branch 'develop' into test.poc-a11y-bottom-shet
OtavioStasiak 854b508
fix: add sleep to pass tests
OtavioStasiak 9feee82
fix: e2e tests
OtavioStasiak b5aaff9
Merge branch 'develop' into reanimated-v4
Rohit3523 6413650
conflict fix
Rohit3523 d0f3d39
Merge branch 'develop' into reanimated-v4
Rohit3523 a8cdebd
Move worklet plugin to last
Rohit3523 ebe4419
Merge branch 'reanimated-v4' of https://github.com/RocketChat/Rocket.…
Rohit3523 b054ed4
fix: roomView test
OtavioStasiak bcbc7fe
fix: e2e tests
OtavioStasiak 8a0d12c
Merge branch 'develop' into test.poc-a11y-bottom-shet
OtavioStasiak 02cd74f
fix: code improvements
OtavioStasiak e50f3ad
fix: update required height
OtavioStasiak af3098d
Update patches/@lodev09+react-native-true-sheet+3.7.3.patch
OtavioStasiak b7c2b2f
code improvements
OtavioStasiak 22ff512
fix: style
OtavioStasiak cc271ef
chore: format code and fix lint issues
OtavioStasiak eb37e68
remove unused style
OtavioStasiak b5a87b7
clean patch package
OtavioStasiak a0a6854
fix: remove border rounded and fixing padding issues
OtavioStasiak ebd8f88
fix: list padding
OtavioStasiak f4defa6
adjust bottom padding
OtavioStasiak d66c812
fix: android Directory view Actionsheet click and Servers List render
OtavioStasiak 7662c7f
fix: orientation and unit test
OtavioStasiak 88e8b42
Merge branch 'develop' into test.poc-a11y-bottom-shet
OtavioStasiak c19cadf
chore: format code and fix lint issues
OtavioStasiak 7946eb4
fix: remve highlight of handle
OtavioStasiak d6a3237
cleanup
OtavioStasiak 6fc21de
more bottom sheet changes
Rohit3523 7d1f242
adjustment for android
Rohit3523 301b0c3
chore: format code and fix lint issues
Rohit3523 8daab95
rerun
Rohit3523 d23a7e0
revert
Rohit3523 7c02045
Merge branch 'test.poc-a11y-bottom-shet' of https://github.com/Rocket…
Rohit3523 38cd2c9
test update
Rohit3523 930c88a
some improvements
Rohit3523 d0d218b
fix test
Rohit3523 3bab462
test fix
Rohit3523 cd35041
Remove unused bottomSheet prop
Rohit3523 35b55df
memorise bottom sheet handle
Rohit3523 50e1ffc
remove unused import
Rohit3523 ec14b28
ios test fix
Rohit3523 28d9062
clear timeout
Rohit3523 fb40b8b
wait for animation to close
Rohit3523 ae5df9f
Merge branch 'develop' into test.poc-a11y-bottom-shet
Rohit3523 fdaf544
lint fix
Rohit3523 05c7b5a
chore: format code and fix lint issues
Rohit3523 5064359
add comment for extra style
Rohit3523 650104e
tap on point to hide sheet
Rohit3523 7144138
Merge branch 'test.poc-a11y-bottom-shet' of https://github.com/Rocket…
Rohit3523 8db5f90
suggested changes by copilot and copilot
Rohit3523 d3f23e7
chore: format code and fix lint issues
Rohit3523 c03938c
revert the test
Rohit3523 4e7cc2b
Merge branch 'test.poc-a11y-bottom-shet' of https://github.com/Rocket…
Rohit3523 0e45349
Change sheet min height
Rohit3523 dbffe97
disable content panning for android
Rohit3523 d33a796
chore: format code and fix lint issues
Rohit3523 719c192
rerun
Rohit3523 1e6da08
revert
Rohit3523 e8abcf1
test update
Rohit3523 8b410dc
correct cancel button height
Rohit3523 b81a3ae
Remove timeout to present sheet
Rohit3523 4a7a9fb
Merge branch 'develop' into react-native-81
Rohit3523 709d7d8
chore: format code and fix lint issues
Rohit3523 9e60c47
Remove space
Rohit3523 449360a
ios fix
Rohit3523 9b1713c
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 3dc77ca
package align
Rohit3523 9c25b88
Added bottom sheet in dev because of storybook
Rohit3523 9ff7576
snap update
Rohit3523 28d8d4e
Test fix
Rohit3523 1ddf1c6
test fix
Rohit3523 54c2e9d
Merge branch 'develop' into reanimated-v4
Rohit3523 a367e02
chore: format code and fix lint issues
Rohit3523 2b3e51a
lock file fixed
Rohit3523 5756896
Merge branch 'develop' into test.poc-a11y-bottom-shet
Rohit3523 45d1292
increase reaction open time
Rohit3523 ac20a76
Merge branch 'test.poc-a11y-bottom-shet' of https://github.com/Rocket…
Rohit3523 cdda960
increase timeout
Rohit3523 cf08b03
Upgrade to RN 0.81.6
Rohit3523 cff02b6
Removed deprecated addWhitelistedNativeProps
Rohit3523 c48a040
Merge branch 'test.poc-a11y-bottom-shet' into reanimated-v4
Rohit3523 175bd53
Merge branch 'reanimated-v4' into react-native-81
Rohit3523 1d7d89d
revert to rn 0.81.5
Rohit3523 bf5c915
snap update
Rohit3523 5042da6
remove worklet from jest
Rohit3523 912278c
Replace thumb button with touch
Rohit3523 2f1ba4a
update expo-file-system import to legacy
Rohit3523 59cae3a
ts fix
Rohit3523 1529a23
patch for webview
Rohit3523 4ed67ee
remove rn web 13.15.0 patch
Rohit3523 0232059
use custom snapshot serializer
Rohit3523 01552c7
snapshot update
Rohit3523 a603042
chore: format code and fix lint issues
Rohit3523 e9590e3
prettier ;-;
Rohit3523 063ce88
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 f80ab8e
pod update
Rohit3523 53d9751
fix for expo-file-system in android
Rohit3523 cdf85b0
Merge branch 'develop' into reanimated-v4
Rohit3523 4ff6637
pod update
Rohit3523 c2a6ca4
Merge branch 'develop' into react-native-81
Rohit3523 31d5e63
lock file fix
Rohit3523 be5e8e9
Merge branch 'develop' into expo-audio
Rohit3523 cfc5f2e
enable liquid glass ui
Rohit3523 2116a2d
list item are not accessible for e2e, so maestro can interact with sw…
Rohit3523 c8a5cce
chore: format code and fix lint issues
Rohit3523 291143b
Merge branch 'develop' into react-native-81
Rohit3523 bdf46e7
Merge branch 'develop' into react-native-81
Rohit3523 21f08c8
revert last change
Rohit3523 fd24f10
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 8048a08
improve logic...
Rohit3523 fbe735c
A temp change
Rohit3523 05cacf5
use rect button
Rohit3523 be81a47
test update
Rohit3523 f3c0d50
use match like in accessibility test
Rohit3523 6929797
ios profile test fix
Rohit3523 d327896
test fix
Rohit3523 09d63d8
Added test id in directory
Rohit3523 951558d
chore: format code and fix lint issues
Rohit3523 b4cd9b5
path fix ;-;
Rohit3523 ee7133d
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 7f5e04d
coderabbit suggestion
Rohit3523 88be3cd
coderabbit suggestion
Rohit3523 6bb597e
Merge branch 'develop' into reanimated-v4
Rohit3523 03e0ae0
seekbar improvement
Rohit3523 a130cd1
Replace more runOnJS to scheduleOnRN
Rohit3523 a541660
Merge branch 'reanimated-v4' of https://github.com/RocketChat/Rocket.…
Rohit3523 6e35a0b
update seekbar
Rohit3523 49eb0d8
Merge branch 'reanimated-v4' into react-native-81
Rohit3523 6d0ef3a
trying to use RectButton in handle
Rohit3523 4688922
chore: format code and fix lint issues
Rohit3523 857ea2c
using TouchableNativeFeedback from RNGH
Rohit3523 8f9b788
readded message parser patch ;-;
Rohit3523 5646bdf
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 9ca79ca
Switch from TouchableNativeFeedback to TouchableHighlight ;-;
Rohit3523 d169c97
chore: format code and fix lint issues
Rohit3523 0125108
rerun ci
Rohit3523 75e2166
revert
Rohit3523 ee646a4
Merge branch 'react-native-81' into expo-audio
Rohit3523 062be8f
lint fix
Rohit3523 10fd51f
eslint fix and api align
Rohit3523 41aaa31
Added changes for expo-video
Rohit3523 c9ac652
Remove expo-av
Rohit3523 f281134
code format
Rohit3523 4db9e2f
fix react hook rule
Rohit3523 59278db
remove plugins because it is not needed
Rohit3523 b01fe2c
fix audio play and seek fix
Rohit3523 e1c28fd
Merge branch 'develop' into expo-audio
Rohit3523 78f1f18
Merge branch 'develop' into expo-audio
Rohit3523 81881b9
changes revert
Rohit3523 380197d
Merge branch 'expo-audio' of https://github.com/RocketChat/Rocket.Cha…
Rohit3523 dd072db
chore: format code and fix lint issues
Rohit3523 097117b
making code rabbit happy
Rohit3523 0725500
making eslint happy...
Rohit3523 60f1eba
mock fix
Rohit3523 f9cc233
more changes
Rohit3523 e38798f
chore: format code and fix lint issues
Rohit3523 13ca710
video player fix
Rohit3523 a819401
Merge branch 'expo-audio' of https://github.com/RocketChat/Rocket.Cha…
Rohit3523 27182e1
Merge branch 'develop' into expo-audio
Rohit3523 8682447
Merge branch 'develop' into expo-audio
Rohit3523 087c7e8
Merge branch 'develop' into expo-audio
Rohit3523 3b9a6a9
pod install
Rohit3523 50e459e
Merge branch 'develop' into expo-audio
Rohit3523 96d5b49
code update
Rohit3523 6ef935f
test update
Rohit3523 97f4d75
making code rabbit happy
Rohit3523 ed07693
chore: format code and fix lint issues
Rohit3523 d74c32a
test fix
Rohit3523 b7f988d
Merge branch 'expo-audio' of https://github.com/RocketChat/Rocket.Cha…
Rohit3523 f761897
Merge branch 'develop' into expo-audio
Rohit3523 1f3a18d
Merge branch 'develop' into expo-audio
Rohit3523 a354032
improvements
Rohit3523 0bea258
remove expo-av
Rohit3523 424f719
Merge branch 'develop' into expo-audio
Rohit3523 56be8c6
Merge branch 'develop' into expo-audio
Rohit3523 01d3838
Merge branch 'develop' into expo-audio
Rohit3523 83237ae
Merge branch 'develop' into expo-audio
Rohit3523 2bf6ad9
Using memo directly
Rohit3523 1802321
test fix
Rohit3523 cadc0e4
make setPositionAsync async
Rohit3523 838c45e
Merge branch 'develop' into expo-audio
Rohit3523 fa95705
lint fix
Rohit3523 7b0ec08
Merge branch 'expo-audio' of https://github.com/RocketChat/Rocket.Cha…
Rohit3523 2668539
changes
Rohit3523 729821a
action: organized translations
Rohit3523 2d645ba
move back to class
Rohit3523 60433f6
Merge branch 'expo-audio' of https://github.com/RocketChat/Rocket.Cha…
Rohit3523 06344d1
Changes
Rohit3523 5d58df8
More changes
Rohit3523 ae39003
Merge branch 'develop' into expo-audio
Rohit3523 1b00101
changes
Rohit3523 9e86240
using PermissionStatus instead of string check
Rohit3523 7816a92
move record back to effect
Rohit3523 c9ec946
readded RECORDING_SETTINGS
Rohit3523 37fa278
fix type
Rohit3523 a063301
more type fix
Rohit3523 49de44f
readded constructor
Rohit3523 13e6e46
position change
Rohit3523 45c3dd8
some more revert
Rohit3523 d713664
more revert
Rohit3523 073e935
lint
Rohit3523 f1793f5
more changes
Rohit3523 97f5654
lint fix
Rohit3523 4554f90
using didJustFinish
Rohit3523 4f3894e
using enum
Rohit3523 228bd17
added return type
Rohit3523 77256b6
remove comment
Rohit3523 9a4ec0b
some changes
Rohit3523 20b6031
using createAudioPlayer in ringer
Rohit3523 5402cb5
fix audio recoding
Rohit3523 dbf1d61
podfile fix
Rohit3523 2b4e753
Added translation
Rohit3523 94ae616
action: organized translations
Rohit3523 876e66e
Merge branch 'develop' into expo-audio
Rohit3523 65039ec
stop playing audio on ios after opening room
Rohit3523 0cf30f0
improvement for ios
Rohit3523 30c3231
correct translation
Rohit3523 efb4f03
remove unwanted code
Rohit3523 d706b0c
Merge branch 'develop' into expo-audio
Rohit3523 740ece7
Merge branch 'develop' into expo-audio
Rohit3523 e3a830d
Merge branch 'develop' into expo-audio
Rohit3523 8c5ac58
recent changes
Rohit3523 86d163c
fix recording on ios
Rohit3523 f33838d
Merge branch 'develop' into expo-audio
Rohit3523 02bbd94
patch to fix seek on android
Rohit3523 68cfa9b
Merge branch 'develop' into expo-audio
Rohit3523 15bcde8
fix config
Rohit3523 6ea0591
Merge branch 'develop' into expo-audio
Rohit3523 c108964
chore: format code and fix lint issues
Rohit3523 d47fb5f
do not play video automatically in shareview
Rohit3523 d988aeb
Merge branch 'develop' into expo-audio
Rohit3523 5b5be6a
changes
Rohit3523 7045b9e
Merge branch 'develop' into expo-audio
Rohit3523 85a45cc
test fix
Rohit3523 471cb29
added safe area in video view and move style to it's own file
Rohit3523 72c184c
chore: format code and fix lint issues
Rohit3523 756e606
fix: VideoPlayer stories snapshot coverage and broken theme exports
Rohit3523 806c0c3
fix: handle permission API failures in MicOrSendButton
Rohit3523 7304eb4
fix: add explicit return types to AudioManager and test setup
Rohit3523 5ca7d61
Merge branch 'develop' into expo-audio
Rohit3523 735ce4a
remove Error_play_video
Rohit3523 c632717
fix: address Otavio review feedback
Rohit3523 e4ad02f
fix: handle floating setPositionAsync promise in AudioPlayer onEnd
Rohit3523 e12e721
Merge branch 'develop' into expo-audio
Rohit3523 ee140b0
Merge branch 'develop' into expo-audio
Rohit3523 d72d2a5
fix: preserve audio pitch, sequential replay and room cleanup
diegolmello b7a01f6
Merge branch 'develop' into expo-audio
diegolmello dc13f5f
fix: preserve seek position and simplify audio recording
diegolmello 846cda3
Merge develop into expo-audio and resolve composer test imports
diegolmello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are temporary storing the current play time, so if the seek fail, we can revert the time