chore: migrate from expo-av to expo-audio and expo-video by Rohit3523 · Pull Request #6719 · RocketChat/Rocket.Chat.ReactNative

Rohit3523 · 2025-10-12T09:43:30Z

Proposed changes

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-2035

How to test or reproduce

Screenshots

Senerio	Android	iOS
Opening a channel displays a play button in the audio message & playing it	Screen.Recording.2026-09-02.at.9.12.58.PM.mov	Screen.Recording.2026-09-02.at.9.14.02.PM.mov
seek bar, playback speed, and pause	Screen.Recording.2026-09-02.at.9.15.10.PM.mov	Screen.Recording.2026-09-02.at.9.14.32.PM.mov
Video message	Screen.Recording.2026-09-02.at.9.07.25.PM.mov	Screen.Recording.2026-09-02.at.9.08.28.PM.mov
Video view: everything is displayed within the safe area
Video ShareView	Screen.Recording.2026-09-02.at.9.20.39.PM.mov	Screen.Recording.2026-09-02.at.9.22.15.PM.mov

Types of changes

Bugfix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves a current function)
New feature (non-breaking change which adds functionality)
Documentation update (if none of the other choices apply)

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if applicable)
I have added necessary documentation (if applicable)
Any dependent changes have been merged and published in downstream modules

Further comments

Summary by CodeRabbit

Refactor
- Migrated audio playback, recording, ringer sounds, and VOIP call-ended playback to a new audio stack.
- Updated attachment and share preview video rendering to a new video player.
Bug Fixes
- Improved audio seek gesture rollback using snapshot-based state restoration and synchronous time updates.
- Improved end-of-playback handling and ensured playback listeners are properly released/cleaned up.
- Enhanced video loading/error handling and pause behavior during navigation transitions.
Chores
- Updated Jest mocks and adjusted media-related tests to match the new playback/recording APIs.

coderabbitai · 2025-10-12T09:43:43Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

Migrates audio and video usage from expo-av to expo-audio and expo-video across recording, playback, VoIP, ringer, previews, tests, and package dependencies, while updating seek and playback-status handling.

Changes

Expo media migration

Layer / File(s)	Summary
Seek and playback status `app/containers/AudioPlayer/Seek.tsx`, `app/containers/AudioPlayer/index.tsx`, `app/containers/AudioPlayer/index.test.tsx`	Seek callbacks become synchronous, failed gestures restore saved values, and playback status handling uses expo-audio fields for UI state, progress, and completion.
Recorder permissions and lifecycle `app/containers/MessageComposer/components/Buttons/MicOrSendButton.tsx`, `app/containers/MessageComposer/components/RecordAudio/*`	Recording permissions and recorder state move to expo-audio, with hook-based recording, stop-based cleanup, and recorder URI/state used for upload and review.
VoIP end-of-call sound and tests `app/lib/services/voip/playCallEndedSound.ts`, `app/lib/services/voip/playCallEndedSound.test.ts`, `app/containers/NewMediaCall/VoipCallLifecycle.integration.test.tsx`	VoIP playback uses a synchronous expo-audio player with watchdog cleanup, and tests cover completion, coalescing, timeout cleanup, and errors.
AudioManager factory and caches `app/lib/methods/AudioManager.ts`	AudioManager uses expo-audio players with per-key caches, listener management, seek/rate restoration, sequence handling, and release-based cleanup.
Video rendering and preview `app/views/AttachmentView.tsx`, `app/views/ShareView/Preview.tsx`, `app/views/AttachmentView.test.tsx`	Attachment and share preview playback use expo-video players and views, with loading, error, blur, and sizing behavior updated.
Ringer playback `app/containers/Ringer/index.tsx`	Ringer playback uses expo-audio player hooks, static sound mappings, looping, and release-based cleanup.
Package dependencies `package.json`	expo-audio replaces expo-av, and expo-video is added.

Estimated code review effort: 4 (Complex) | ~60 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 5.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the primary change: migrating audio functionality from expo-av to expo-audio and expo-video.

Fix all pre-merge checks with AI

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

CORE-2035: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Rohit3523 · 2025-10-12T15:39:15Z

Recording is not working... idk why...

…Chat.ReactNative into reanimated-v4

github-actions · 2026-08-03T14:35:49Z

Android Build Available

Rocket.Chat 4.75.0.109484

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNSvJTsy5k9ssHHPKey_G8zekwXkcBRL48cOMXYZpDLvJSE55L5lpqty9GgOCpoWvCaezIJOngcxDy0xLUUt

github-actions · 2026-08-03T16:08:31Z

iOS Build Available

Rocket.Chat 4.75.0.109485

github-actions · 2026-08-07T20:40:46Z

Android Build Available

Rocket.Chat 4.76.0.109504

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNT8o5CTVGoU6889_W6QRx-ZFHVLMJdmmNqmpq7ahPdgjh8y01zYym3NZ4grxWeczZULdqo07HG_zA4nw8Ln

github-actions · 2026-08-07T21:01:28Z

iOS Build Available

Rocket.Chat 4.76.0.109505

github-actions · 2026-08-12T19:43:00Z

Android Build Available

Rocket.Chat 4.76.0.109510

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNSnIRA5XX9VKv0K5ba0oaAm3bd56A8xZF1f5JCcIjgoE5xteqdmVXWtWLMmDRrhJUnhkplqoEahTzePbJSS

github-actions · 2026-08-12T20:03:23Z

iOS Build Available

Rocket.Chat 4.76.0.109511

github-actions · 2026-08-20T10:53:28Z

iOS Build Available

Rocket.Chat 4.76.0.1

github-actions · 2026-08-20T11:01:23Z

Android Build Available

Rocket.Chat 4.76.0.1

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNQDPEhsVBBTkyRg_qAj9qGErObVRWKB6ThSxu38pGZgSz1LXm3uVAsWZeeSDFzEYKCmFRUi-sEOzJ4t6yHB

github-actions · 2026-08-24T13:45:12Z

Android Build Available

Rocket.Chat 4.76.0.109533

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNQ5BkDZegCsqi5EwvE5yp16Iq-KdPtHuS0L9-4q3bCTG9u7xbrVgWKMqGqcjsxbsOh_pTAme1hYMi3_5ZWF

github-actions · 2026-08-24T13:51:47Z

iOS Build Available

Rocket.Chat 4.76.0.109534

Rohit3523 · 2026-09-02T14:23:24Z

On Android, we were previously using MediaPlayer through expo-av

Rocket.Chat.ReactNative/app/lib/methods/AudioManager.ts

Line 39 in 2edc50b

const { sound } = await Audio.Sound.createAsync({ uri }, { androidImplementation: 'MediaPlayer' });

Note: Above code is from develop branch

With the migration to expo-audio, the Android implementation switched to ExoPlayer and seeking stopped working for some audio files.

This patch enables constant-bitrate seeking in ExoPlayer, which fixes the seeking behavior for those files.

github-actions · 2026-09-02T16:45:00Z

Android Build Available

Rocket.Chat 4.77.0.109570

Internal App Sharing: https://play.google.com/apps/test/RQQ8k09hlnQ/ahAO29uNR_M8VrogC7yAKmJFAlAkHBnAMfbCt3UAJpZVBc1MjFI7_Y6Z_GoPlc_kPX06zC7U2DzjkwWkGldiytYQlN

github-actions · 2026-09-02T16:52:57Z

iOS Build Available

Rocket.Chat 4.77.0.109571

Rohit3523 mentioned this pull request Oct 13, 2025

bug: [Android] APK not compatible with 16KB page size - Google Play deadline Nov 1, 2025 #6621

Closed

Rohit3523 had a problem deploying to approve_e2e_testing February 18, 2026 15:57 — with GitHub Actions Failure

OtavioStasiak and others added 26 commits March 6, 2026 12:58

cleanup

2f535e3

fix: padding on list and custom actionSheet content

3776737

fix: actionsheet + gesture handler compatibility

7f04181

rollback Pressable

40d9fb9

fix: pressable emoji

f868d6d

chore: comment

504d378

fix: action sheet custom content height

54698cb

fix: directory test

9ed2a82

fix: emoji picker

baca611

fix: close action sheet

fd97518

fix: bottom sheet emoji picker scroll and padding

deb038d

chore: format code and fix lint issues

6afa789

fix: bottomSheet iOS weird padding

3937eec

Merge branch 'develop' into test.poc-a11y-bottom-shet

acd8675

fix: add sleep to pass tests

854b508

fix: e2e tests

9feee82

Merge branch 'develop' into reanimated-v4

b5aaff9

conflict fix

6413650

Merge branch 'develop' into reanimated-v4

d0f3d39

Move worklet plugin to last

a8cdebd

Merge branch 'reanimated-v4' of https://github.com/RocketChat/Rocket.…

ebe4419

…Chat.ReactNative into reanimated-v4

fix: roomView test

b054ed4

fix: e2e tests

bcbc7fe

Merge branch 'develop' into test.poc-a11y-bottom-shet

8a0d12c

fix: code improvements

02cd74f

fix: update required height

e50f3ad

OtavioStasiak requested changes Aug 7, 2026

View reviewed changes

Comment thread app/containers/MessageComposer/components/RecordAudio/RecordAudio.tsx Outdated

Comment thread app/containers/VideoPlayer/index.tsx

Comment thread app/containers/VideoPlayer/index.tsx

Rohit3523 added 2 commits August 8, 2026 00:46

Merge branch 'develop' into expo-audio

e3a830d

recent changes

8c5ac58

fix recording on ios

86d163c

Rohit3523 added 3 commits August 19, 2026 02:46

Merge branch 'develop' into expo-audio

f33838d

patch to fix seek on android

02bbd94

Merge branch 'develop' into expo-audio

68cfa9b

Rohit3523 and others added 3 commits August 23, 2026 20:16

fix config

15bcde8

Merge branch 'develop' into expo-audio

6ea0591

chore: format code and fix lint issues

c108964

Rohit3523 and others added 7 commits September 2, 2026 18:09

do not play video automatically in shareview

d47fb5f

Merge branch 'develop' into expo-audio

d988aeb

changes

5b5be6a

Merge branch 'develop' into expo-audio

7045b9e

test fix

85a45cc

added safe area in video view and move style to it's own file

471cb29

chore: format code and fix lint issues

72c184c

Rohit3523 commented Sep 2, 2026

View reviewed changes

Uh oh!

Conversation

Rohit3523 commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

Checklist

Further comments

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

❌ Failed checks (1 warning)

Review ran into problems

Uh oh!

Rohit3523 commented Oct 12, 2025

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

github-actions Bot commented Aug 3, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 7, 2026

Uh oh!

github-actions Bot commented Aug 12, 2026

Uh oh!

github-actions Bot commented Aug 12, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

github-actions Bot commented Aug 24, 2026

Uh oh!

Rohit3523 Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 2, 2026

Uh oh!

github-actions Bot commented Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Rohit3523 commented Oct 12, 2025 •

edited

Loading

coderabbitai Bot commented Oct 12, 2025 •

edited

Loading

Rohit3523 Sep 2, 2026 •

edited

Loading