[FIX] Share Extension shows a server that has no user logged in - #4336
Merged
Conversation
diegolmello
requested changes
Jul 5, 2022
diegolmello
left a comment
diegolmello
left a comment
Member
There was a problem hiding this comment.
I think the solution is a lot clever than the other one, but it's not free of bugs :)
- Open the app
- Login on
open - Close the app and reopen
- You're now logged out
- Only if you tap
join community, it's going to triggerhandleSelectServerwith a user.
Maybe we should add a logic like that to loginSuccess?
diegolmello
approved these changes
Jul 18, 2022
dnlsilva
force-pushed
the
fix.share-extension-not-logged-in-v2
branch
from
July 20, 2022 20:43
e35bba5 to
b37d9ee
Compare
diegolmello
pushed a commit
that referenced
this pull request
Sep 12, 2022
* [FIX] Share Extension shows a server that has no user logged in * set server after login
navislavo
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
…etChat#4336) * [FIX] Share Extension shows a server that has no user logged in * set server after login
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Changes the logic to only set the chosen server if the login is successful.
Since it is not necessary to set the server and I have not even completed the login.
Note: If it is necessary to keep the server even not logging into it, the right thing would be to create a key, something like a temp key, different from the main key that indicates the logged server.
Closes #4291
I left the old PR just for history and in case you want to compare.
Issue(s)
How to test or reproduce
1 - Start the process of logging in to a server by choosing one, but do not log in to any user account.
a - If this step is not done correctly, at step 4, the user will probably see the screen stating there is no server logged in.
2 - Minimize app
3 - Open Share Extension (by sharing something from the device's gallery)
4 - Try choosing a server to share the file to.
Screenshots
Types of changes
Checklist
Further comments