[FIX] Share Extension shows a server that has no user logged in - #4291
Closed
reinaldonetof wants to merge 2 commits into
Closed
[FIX] Share Extension shows a server that has no user logged in#4291reinaldonetof wants to merge 2 commits into
reinaldonetof wants to merge 2 commits into
Conversation
dnlsilva
suggested changes
Jun 8, 2022
| import { NativeModules } from 'react-native'; | ||
|
|
||
| import { isIOS } from '../methods/helpers'; | ||
| import { isIOS } from '../methods/helpers/deviceInfo'; |
| import logger from '@nozbe/watermelondb/utils/common/logger'; | ||
|
|
||
| import { isIOS } from '../methods/helpers'; | ||
| import { isIOS } from '../methods/helpers/deviceInfo'; |
dnlsilva
approved these changes
Jun 13, 2022
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
How to test or reproduce
1 - Start the process of logging in to a server by choosing one, but do not log in to any user account.
a - If this step is not done correctly, at step 4, the user will probably see the screen stating there is no server logged in.
2 - Minimize app
3 - Open Share Extension (by sharing something from the device's gallery)
4 - Try choosing a server to share the file to.
Screenshots
Before
Screen.Recording.2022-06-08.at.00.28.38.mov
After
Screen.Recording.2022-06-08.at.00.26.30.mov
Types of changes
Checklist
Further comments