Chore: Upgrade React Native to 0.68.2 - #4316
Merged
Merged
Conversation
diegolmello
reviewed
Jul 7, 2022
diegolmello
force-pushed
the
upgrade-react-native-68
branch
from
July 27, 2022 16:38
48fb9f3 to
74c0a82
Compare
Member
|
After a long time trying to figure out why it would compile perfectly from Xcode, but not from Terminal I found this https://gist.github.com/LeZuse/bf838718ff2689c5fc035c5a6825a11c Apparently, we have to have everything running Rosetta, but Node 16 is going to use ARM no no matter what. Following that gist to install Node 14.20 did the trick for me :) |
10 tasks
|
This pull request introduces 2 alerts when merging 082a63b into 5875454 - view on LGTM.com new alerts:
|
diegolmello
marked this pull request as ready for review
August 1, 2022 16:25
|
This pull request introduces 2 alerts when merging b89380f into 5875454 - view on LGTM.com new alerts:
|
diegolmello
approved these changes
Aug 8, 2022
|
This pull request introduces 2 alerts when merging 96a6794 into e38aedc - view on LGTM.com new alerts:
|
12 tasks
diegolmello
added a commit
that referenced
this pull request
Sep 12, 2022
Co-authored-by: Diego Mello <diegolmello@gmail.com>
10 tasks
navislavo
pushed a commit
to NextiaDev/Rocket.Chat.ReactNative
that referenced
this pull request
May 26, 2023
Co-authored-by: Diego Mello <diegolmello@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrades React Native to 0.68.2, which is a huge jump from 0.64.2.
Issue(s)
Depends on RocketChat/rn-root-view#3
Depends on https://github.com/RocketChat/react-native/tree/0.68.2
How to test or reproduce
Screenshots
This PR left side vs Production app right side
Running on Samsung S10e.
I didn't find a visible difference in performance on iOS.
RN68.mp4
Types of changes
Checklist
Further comments