Skip to content

Chore: Upgrade React Native to 0.68.2 - #4316

Merged
diegolmello merged 71 commits into
developfrom
upgrade-react-native-68
Aug 8, 2022
Merged

Chore: Upgrade React Native to 0.68.2#4316
diegolmello merged 71 commits into
developfrom
upgrade-react-native-68

Conversation

@dnlsilva

@dnlsilva dnlsilva commented Jun 24, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Upgrades React Native to 0.68.2, which is a huge jump from 0.64.2.

Issue(s)

Depends on RocketChat/rn-root-view#3
Depends on https://github.com/RocketChat/react-native/tree/0.68.2

How to test or reproduce

  • We need to test it deeper than a beta, because things might break
    • For example, attachment zoom was failing and I had to fix

Screenshots

This PR left side vs Production app right side

Running on Samsung S10e.
I didn't find a visible difference in performance on iOS.

RN68.mp4

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Comment thread ios/RocketChatRN/AppDelegate.m
@diegolmello
diegolmello force-pushed the upgrade-react-native-68 branch from 48fb9f3 to 74c0a82 Compare July 27, 2022 16:38
@diegolmello

Copy link
Copy Markdown
Member

After a long time trying to figure out why it would compile perfectly from Xcode, but not from Terminal I found this https://gist.github.com/LeZuse/bf838718ff2689c5fc035c5a6825a11c

Apparently, we have to have everything running Rosetta, but Node 16 is going to use ARM no no matter what.

Following that gist to install Node 14.20 did the trick for me :)

@lgtm-com

lgtm-com Bot commented Aug 1, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging 082a63b into 5875454 - view on LGTM.com

new alerts:

  • 2 for Unknown directive

@diegolmello diegolmello changed the title Upgrade react native 68 Upgrade React Native to 0.68.2 Aug 1, 2022
@diegolmello
diegolmello marked this pull request as ready for review August 1, 2022 16:25
@lgtm-com

lgtm-com Bot commented Aug 1, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging b89380f into 5875454 - view on LGTM.com

new alerts:

  • 2 for Unknown directive

@lgtm-com

lgtm-com Bot commented Aug 8, 2022

Copy link
Copy Markdown

This pull request introduces 2 alerts when merging 96a6794 into e38aedc - view on LGTM.com

new alerts:

  • 2 for Unknown directive

@diegolmello diegolmello changed the title Upgrade React Native to 0.68.2 Chore: Upgrade React Native to 0.68.2 Aug 8, 2022
@diegolmello
diegolmello merged commit 2b08b68 into develop Aug 8, 2022
@diegolmello
diegolmello deleted the upgrade-react-native-68 branch August 8, 2022 21:02
diegolmello added a commit that referenced this pull request Sep 12, 2022
Co-authored-by: Diego Mello <diegolmello@gmail.com>
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Co-authored-by: Diego Mello <diegolmello@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants