Chore: Migrate App/index.tsx to hooks - #4401
Closed
reinaldonetof wants to merge 11 commits into
Closed
Conversation
|
Hello. I was reviewing about hooks in react native and I found this way to hook consts using usereducer, I think this can help in clean code |
diegolmello
reviewed
Aug 1, 2022
diegolmello
reviewed
Aug 1, 2022
diegolmello
reviewed
Aug 1, 2022
diegolmello
reviewed
Aug 1, 2022
diegolmello
reviewed
Aug 1, 2022
diegolmello
reviewed
Aug 1, 2022
diegolmello
reviewed
Aug 1, 2022
diegolmello
reviewed
Aug 1, 2022
| // change theme state | ||
| this.setState( | ||
| prevState => newThemeState(prevState, newTheme as IThemePreference), | ||
| prevState => newThemeState(prevState.themePreferences, newTheme as IThemePreference), |
Contributor
Author
There was a problem hiding this comment.
Because I changed the function newThemeState to receive only the property required, not the state completely.
diegolmello
reviewed
Aug 1, 2022
diegolmello
reviewed
Aug 1, 2022
diegolmello
reviewed
Aug 1, 2022
diegolmello
requested changes
Aug 19, 2022
dnlsilva
approved these changes
Sep 16, 2022
dnlsilva
left a comment
Contributor
There was a problem hiding this comment.
Add a comment to your task saying that it has to be well tested.
All app works.
Open and close, push etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Migrate the App/index.tsx to hooks.
This is the second file, after the index.js. Here we start with a lot of providers, the redux and some modals.
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Further comments
Jira: NATIVE-45