-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[FIX] Evaluate values in handle failure #3235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
diegolmello
merged 19 commits into
develop
from
fix.evaluate-vals-handle-failure-bugsnag
Aug 27, 2021
+25
−3
Merged
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5b30f16
[FIX] HEvaluating proper the error for channel, team and undefined
reinaldonetof 3e0c5bf
Added some team errors in i18n
reinaldonetof ffdeb6c
Added unauthorized to i18n
reinaldonetof 17efa73
Test if there is channel name too, to prevent to show {missing roomName}
reinaldonetof 2690ef1
Refactor the treatment error to check if exists before translate with…
reinaldonetof bafd890
Merge branch 'develop' into fix.evaluate-vals-handle-failure-bugsnag
reinaldonetof dbac8cc
Remove some check conditional points
reinaldonetof 6aae765
Merge branch 'develop' into fix.evaluate-vals-handle-failure-bugsnag
reinaldonetof 62ab637
Minor tweak
gerzonc bc3f7c0
Merge branch 'develop' into fix.evaluate-vals-handle-failure-bugsnag
gerzonc 60c6600
Merge branch 'develop' into fix.evaluate-vals-handle-failure-bugsnag
reinaldonetof 1ff53f0
Merge branch 'develop' into fix.evaluate-vals-handle-failure-bugsnag
reinaldonetof 56a007b
Merge branch 'develop' into fix.evaluate-vals-handle-failure-bugsnag
reinaldonetof 47acf5c
Added array with error inside the createChannel
reinaldonetof 85b78e1
Merge branch 'develop' into fix.evaluate-vals-handle-failure-bugsnag
gerzonc fdf31e4
Moved error array to inside the handleFailure
reinaldonetof 1ad7d87
Merge branch 'develop' into fix.evaluate-vals-handle-failure-bugsnag
reinaldonetof b85ea7f
added creating_discussion
reinaldonetof a5c90f4
Merge branch 'develop' into fix.evaluate-vals-handle-failure-bugsnag
diegolmello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.