[IMPROVEMENT] User Can Copy Link On hold #1684
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,17 @@ | ||
| import React from 'react'; | ||
| import { | ||
| View, | ||
| Text, | ||
| StyleSheet, | ||
| Clipboard, | ||
| ToastAndroid, | ||
| Platform, | ||
| Vibration | ||
| } from 'react-native'; | ||
| import PropTypes from 'prop-types'; | ||
| import FastImage from 'react-native-fast-image'; | ||
| import Touchable from 'react-native-platform-touchable'; | ||
| import isEqual from 'lodash/isEqual'; | ||
|
Comment on lines
1
to
8
Contributor
There was a problem hiding this comment. Please, undo all changes in this file.
Contributor
Author
There was a problem hiding this comment. Yeah, they'll be undone |
||
|
Contributor
There was a problem hiding this comment. Undo these changes. |
||
| import openLink from '../../utils/openLink'; | ||
| import sharedStyles from '../../views/Styles'; | ||
| import { themes } from '../../constants/colors'; | ||
|
|
@@ -81,10 +88,19 @@ const Url = React.memo(({ | |
| } | ||
|
|
||
| const onPress = () => openLink(url.url, theme); | ||
|
djorkaeffalexandre marked this conversation as resolved.
|
||
| const onLongPress = () => { | ||
| Clipboard.setString(url.url); | ||
| if (Platform.os === 'ios') { | ||
| Vibration.vibrate(); | ||
| } else { | ||
| Vibration.vibrate(200); | ||
| ToastAndroid.show('Link copied', ToastAndroid.SHORT); | ||
| } | ||
| }; | ||
|
Comment on lines
+91
to
+93
Contributor
There was a problem hiding this comment. For first, you don't need to use
Contributor
Author
There was a problem hiding this comment. Ok, Thanks for the guidance. 👍 |
||
| return ( | ||
| <Touchable | ||
| onPress={onPress} | ||
| onLongPress={onLongPress} | ||
| style={[ | ||
| styles.button, | ||
| index > 0 && styles.marginTop, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included Clipboard, Vibrations, Platform modules of react-native which are not required by Url.js as they aren't required there. I included them for fixing the issue but you redirected me to our own Toast.js component, therefore, I removed the modules.
I'll revert them.