Skip to content

[IMPROVEMENT] User Can Copy Link On hold #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 13 commits into from
Feb 14, 2020
Merged

[IMPROVEMENT] User Can Copy Link On hold #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
60fb8c3
[IMPROVEMENT] User Can Copy Link On hold
Feb 8, 2020
eb1a098
IMPROVEMENTS
Feb 8, 2020
8b3d2ee
Corrected code formatting
Feb 8, 2020
03e79e0
Cleaning app/containers/message/Urls.js and removing the onLongPress.js
Feb 9, 2020
07a3a90
Reverting to "Corrected code formatting"
Feb 9, 2020
84913b4
Reverting Back
Feb 9, 2020
7a8f5ed
Fixed Formatting
Feb 9, 2020
44fe2a4
Added mocks for react-native-firebase and bugsnag
Feb 12, 2020
40d3513
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
Feb 12, 2020
4a280f0
Update:
Feb 12, 2020
80c3b56
Reverted all the changes in Url.js
Feb 12, 2020
76de1fb
Add i18n and longPress to URL
djorkaeffalexandre Feb 14, 2020
0661d33
Merge branch 'develop' into Sarthak-copyLink
djorkaeffalexandre Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions __mocks__/bugsnag-react-native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
export class Client { }

export default {
bugsnag: () => '',
leaveBreadcrumb: () => '',
notify: () => '',
loggerConfig: () => ''
};
3 changes: 3 additions & 0 deletions __mocks__/react-native-firebase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default {
analytics: null
};
3 changes: 3 additions & 0 deletions __tests__/__snapshots__/Storyshots.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27460,6 +27460,7 @@ exports[`Storyshots Message list message 1`] = `
Support
</Text>
<Text
onLongPress={[Function]}
onPress={[Function]}
style={
Object {
Expand Down Expand Up @@ -27531,6 +27532,7 @@ exports[`Storyshots Message list message 1`] = `

</Text>
<Text
onLongPress={[Function]}
onPress={[Function]}
style={
Object {
Expand Down Expand Up @@ -27666,6 +27668,7 @@ exports[`Storyshots Message list message 1`] = `

</Text>
<Text
onLongPress={[Function]}
onPress={[Function]}
style={
Object {
Expand Down
10 changes: 9 additions & 1 deletion app/containers/markdown/Link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import React from 'react';
import PropTypes from 'prop-types';
import { Text } from 'react-native';
import { Text, Clipboard } from 'react-native';

import styles from './styles';
import { themes } from '../../constants/colors';
import openLink from '../../utils/openLink';
import { LISTENER } from '../Toast';
import EventEmitter from '../../utils/events';
import I18n from '../../i18n';

const Link = React.memo(({
children, link, preview, theme
Expand All @@ -17,11 +20,16 @@ const Link = React.memo(({
};

const childLength = React.Children.toArray(children).filter(o => o).length;
const onLongPress = () => {
Clipboard.setString(link);
EventEmitter.emit(LISTENER, { message: I18n.t('Copied_to_clipboard') });
};

// if you have a [](https://rocket.chat) render https://rocket.chat
return (
<Text
onPress={preview ? undefined : handlePress}
onLongPress={preview ? undefined : onLongPress}
style={
!preview
? { ...styles.link, color: themes[theme].actionTintColor }
Expand Down
13 changes: 12 additions & 1 deletion app/containers/message/Urls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import React from 'react';
import { View, Text, StyleSheet } from 'react-native';
import {
View, Text, StyleSheet, Clipboard
} from 'react-native';
import PropTypes from 'prop-types';
import FastImage from 'react-native-fast-image';
import Touchable from 'react-native-platform-touchable';
Expand All @@ -10,6 +12,9 @@ import sharedStyles from '../../views/Styles';
import { themes } from '../../constants/colors';
import { withTheme } from '../../theme';
import { withSplit } from '../../split';
import { LISTENER } from '../Toast';
import EventEmitter from '../../utils/events';
import I18n from '../../i18n';

const styles = StyleSheet.create({
button: {
Expand Down Expand Up @@ -82,9 +87,15 @@ const Url = React.memo(({

const onPress = () => openLink(url.url, theme);

const onLongPress = () => {
Clipboard.setString(url.url);
EventEmitter.emit(LISTENER, { message: I18n.t('Copied_to_clipboard') });
};

return (
<Touchable
onPress={onPress}
onLongPress={onLongPress}
style={[
styles.button,
index > 0 && styles.marginTop,
Expand Down