Skip to content

[IMPROVEMENT] User Can Copy Link On hold #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegolmello merged 13 commits into from
Feb 14, 2020
Merged

[IMPROVEMENT] User Can Copy Link On hold #1684

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
60fb8c3
[IMPROVEMENT] User Can Copy Link On hold
Feb 8, 2020
eb1a098
IMPROVEMENTS
Feb 8, 2020
8b3d2ee
Corrected code formatting
Feb 8, 2020
03e79e0
Cleaning app/containers/message/Urls.js and removing the onLongPress.js
Feb 9, 2020
07a3a90
Reverting to "Corrected code formatting"
Feb 9, 2020
84913b4
Reverting Back
Feb 9, 2020
7a8f5ed
Fixed Formatting
Feb 9, 2020
44fe2a4
Added mocks for react-native-firebase and bugsnag
Feb 12, 2020
40d3513
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
Feb 12, 2020
4a280f0
Update:
Feb 12, 2020
80c3b56
Reverted all the changes in Url.js
Feb 12, 2020
76de1fb
Add i18n and longPress to URL
djorkaeffalexandre Feb 14, 2020
0661d33
Merge branch 'develop' into Sarthak-copyLink
djorkaeffalexandre Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/containers/markdown/Link.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import React from 'react';
import PropTypes from 'prop-types';
import { Text } from 'react-native';
import { Text, Clipboard } from 'react-native';

import styles from './styles';
import { themes } from '../../constants/colors';
import openLink from '../../utils/openLink';
import { LISTENER } from '../Toast';
import EventEmitter from '../../utils/events';

const Link = React.memo(({
children, link, preview, theme
Expand All @@ -17,11 +19,16 @@ const Link = React.memo(({
};

const childLength = React.Children.toArray(children).filter(o => o).length;
const onLongPress = () => {
Clipboard.setString(link);
EventEmitter.emit(LISTENER, { message: 'Copied_to_clipboard' });
};

// if you have a [](https://rocket.chat) render https://rocket.chat
return (
<Text
onPress={preview ? undefined : handlePress}
onLongPress={onLongPress}

@djorkaeffalexandre djorkaeffalexandre Feb 8, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to handle preview cases.

@sarthakpranesh sarthakpranesh Feb 9, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview Cases are handled by the onPress function already.

@djorkaeffalexandre djorkaeffalexandre Feb 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we not want that when user long press a link on roomsListView this link are copy. Use some condition like on onPress.

@sarthakpranesh sarthakpranesh Feb 11, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will apply some conditions

style={
!preview
? { ...styles.link, color: themes[theme].actionTintColor }
Expand Down
19 changes: 16 additions & 3 deletions app/containers/message/Urls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,24 @@
import React from 'react';
import { View, Text, StyleSheet } from 'react-native';
import {
View,
Text,
StyleSheet,
Clipboard,
ToastAndroid,
Platform,
Vibration
} from 'react-native';
Comment on lines +2 to +4

@djorkaeffalexandre djorkaeffalexandre Feb 8, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these changes.

@sarthakpranesh sarthakpranesh Feb 9, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included Clipboard, Vibrations, Platform modules of react-native which are not required by Url.js as they aren't required there. I included them for fixing the issue but you redirected me to our own Toast.js component, therefore, I removed the modules.
I'll revert them.

import PropTypes from 'prop-types';
import FastImage from 'react-native-fast-image';
import Touchable from 'react-native-platform-touchable';
import isEqual from 'lodash/isEqual';
Comment on lines 1 to 8

@djorkaeffalexandre djorkaeffalexandre Feb 11, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, undo all changes in this file.

@sarthakpranesh sarthakpranesh Feb 11, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they'll be undone


@djorkaeffalexandre djorkaeffalexandre Feb 8, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo these changes.

import openLink from '../../utils/openLink';
import sharedStyles from '../../views/Styles';
import { themes } from '../../constants/colors';
import { withTheme } from '../../theme';
import { withSplit } from '../../split';
import { LISTENER } from '../Toast';
import EventEmitter from '../../utils/events';

const styles = StyleSheet.create({
button: {
Expand Down Expand Up @@ -81,10 +90,14 @@ const Url = React.memo(({
}

const onPress = () => openLink(url.url, theme);

Comment thread
djorkaeffalexandre marked this conversation as resolved.
const onLongPress = () => {
Clipboard.setString(url.url);
EventEmitter.emit(LISTENER, { message: 'Copied_to_clipboard' });
};
Comment on lines +91 to +93

@djorkaeffalexandre djorkaeffalexandre Feb 8, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For first, you don't need to use ToastAndroid, we have our own Toast Component, you can search on our code how to use this.
I don't think you need to add some vibration when a link was copied, only the Toast is a feedback great.

@sarthakpranesh sarthakpranesh Feb 8, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Thanks for the guidance. 👍

return (
<Touchable
onPress={onPress}
onLongPress={onLongPress}
style={[
styles.button,
index > 0 && styles.marginTop,
Expand Down