Skip to content

When we listen to any audio message then it will be good if the time is displayed #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devyaniChoubey wants to merge 3 commits into from
Closed

When we listen to any audio message then it will be good if the time is displayed #1607

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
afd5e05
When we listen to any audio message then it will be good if the timer…
devyaniChoubey Jan 21, 2020
0d6e51f
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat.R…
devyaniChoubey Mar 6, 2020
ec35103
fixed
devyaniChoubey Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/containers/message/Audio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ class Audio extends React.Component {
onValueChange={this.onValueChange}
thumbImage={isIOS && { uri: 'audio_thumb', scale: Dimensions.get('window').scale }}
/>
<Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>{this.duration}</Text>
{paused ? <Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>{this.duration}</Text> : <Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>{formatTime(currentTime)}</Text>}

@diegolmello diegolmello Feb 17, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole <Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>...</Text> is repeated twice.
Why not creating a new variable and use it like this?

<Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>
    {newVariable}
</Text>

</View>
<Markdown msg={description} baseUrl={baseUrl} username={user.username} getCustomEmoji={getCustomEmoji} useMarkdown={useMarkdown} theme={theme} />
</>
Expand Down