When we listen to any audio message then it will be good if the time is displayed #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolmello
requested changes
Feb 17, 2020
app/containers/message/Audio.js
Outdated
| thumbImage={isIOS && { uri: 'audio_thumb', scale: Dimensions.get('window').scale }} | ||
| /> | ||
| <Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>{this.duration}</Text> | ||
| {paused ? <Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>{this.duration}</Text> : <Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>{formatTime(currentTime)}</Text>} |
Member
There was a problem hiding this comment.
The whole <Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>...</Text> is repeated twice.
Why not creating a new variable and use it like this?
<Text style={[styles.duration, { color: themes[theme].auxiliaryText }]}>
{newVariable}
</Text>
Contributor
Author
|
@diegolmello sorry sir for late reply I was busy in my college exams. |
Contributor
There was a problem hiding this comment.
All we need to do is update the get duration function. We need to deconstruct one more prop currentTime and then minus it to the duration in the return statement. That should do it. By doing so we'll be able to see how much time is left, to do the reverse only pass the currentTime.
Contributor
Author
|
@sarthakpranesh I will try to do the changes today only.Please let me do it. I was busy in my college exams. |
Contributor
|
Refer to #2073. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
@RocketChat/ReactNative
Closes #1557