Rewrite connect2 to be a lot simpler #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LPGhatguy
force-pushed
the
rewrite-connect2
branch
from
a16e1e1
to
d70b50b
Compare
LPGhatguy
changed the title
ZoteTheMighty
suggested changes
May 16, 2018
lib/connect2.lua
Outdated
| self.mapStateToProps = mapStateToProps | ||
|
|
||
| -- All of the values that we put into state are intended to be used | ||
| -- by getDerivedStateFromProps, constructed using makeStateUpdater. |
There was a problem hiding this comment.
Technically, the mappedStoreDispatch is only used in the stateUpdater itself, but both of those contexts have no knowledge of self. Maybe could word this a little more clearly
lib/connect2.lua
Outdated
| @@ -28,7 +28,7 @@ local function makeStateUpdater(store, mapStateToProps) | |||
| -- The caller can optionally provide mappedStoreState if it needed that | |||
| -- value beforehand. Doing so is purely an optimization. | |||
| if mappedStoreState == nil then | |||
| mappedStoreState = mapStateToProps(store:getState(), nextProps) | |||
| mappedStoreState = prevState.mapStateToProps(store:getState(), nextProps) | |||
There was a problem hiding this comment.
Don't forget to remove the mapStateToProps argument to makeStateUpdater
ZoteTheMighty
approved these changes
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9.
There are a number of prop/state synchronization bugs in the current
connect2implementation, one of which is outlined in #9. I'm essentially rewriting most of the interesting logic from the ground up.I'm hoping to pattern some work based on reduxjs/react-redux#919 but while also trying to keep the complexity low. React-Redux's
connectAdvancedfunction seems significantly more complicated than we need.