Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect2 uses stale state when depending on props changes #9

Closed
LPGhatguy opened this issue May 15, 2018 · 0 comments
Closed

connect2 uses stale state when depending on props changes #9

LPGhatguy opened this issue May 15, 2018 · 0 comments
Labels
bug

Comments

@LPGhatguy
Copy link
Contributor

In the current connect2 implementation, we access prevState.storeState at some point without having updated it. This results in some super confusing bugs relating to stale state being used in some components.

The equivalent code in react-redux is here.

This is a bug I'll be taking a look at tomorrow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LPGhatguy