ref(v28): No undici

[RobinTail]

Using built-in Node.js methods for testing graceful shutdown.

Alternative to #3294

[pullfrog]

Reviewed PR #3295 — submitted 2 inline comments (return type duplication, lost pipelining test coverage) and flagged a stale undici entry in pnpm-workspace.yaml. No blocking issues found; helpers are correct and the migration is clean.

Task list (5/5 completed)

• Read the diff and understand the changes
• Analyze the removed test case and its coverage implications
• Check for stale references to undici in the codebase
• Evaluate the new helper functions for correctness
• Draft and submit review

  ^{｜ View workflow run ｜ Triggered by Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aa6d4e5c-4773-4105-8b5f-d8db60c247e9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch no-undici

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coveralls-official]

coverage: 100.0%. remained the same
when pulling 23ec1f1 on no-undici
into 377fc3e on make-v28.

[pullfrog]

Clean removal of undici in favor of built-in http/https — the helpers are correct and the test suite reads well. One stale config entry to clean up.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

pnpm-workspace.yaml:37 still lists undici in minimumReleaseAgeExclude — now dead config since the dependency is removed.

  ^{｜ View workflow run ｜ Triggered by Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

Acknowledged the author's fix in 39bd3eec (extracted HttpResult interface) and resolved the thread. No code changes needed — the author addressed the feedback directly.

Task list (2/3 completed)

• Reply to RobinTail's comment acknowledging the fix
• Resolve the addressed thread
• Report progress

  ^{｜ View workflow run ｜ Triggered by Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[pullfrog]

No code changes needed — the author had already restored the pipelined-socket test in 98ca985d. Acknowledged the fix and resolved the thread.

  ^{｜ View workflow run ｜ Triggered by Pullfrog ｜ Using Claude Opus ｜ 𝕏}

[RobinTail]

choosing to upgrade undici in #3294