Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v2 addon, use pnpm #945

Merged
merged 33 commits into from
Jan 31, 2023
Merged

Update to v2 addon, use pnpm #945

merged 33 commits into from
Jan 31, 2023

Conversation

RobbieTheWagner
Copy link
Owner

No description provided.

@@ -0,0 +1,36 @@


name: Setup node and pnpm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah, this got bonkers -- was there a regression in pnpm support from setup-node?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. Was trying things since I noticed the suggested config was different from what we had.

@RobbieTheWagner RobbieTheWagner marked this pull request as ready for review January 30, 2023 20:31
@RobbieTheWagner RobbieTheWagner changed the title Update to v2 addon, use pnpm, docs rewrite Update to v2 addon, use pnpm Jan 31, 2023
@RobbieTheWagner RobbieTheWagner merged commit 790ebd1 into main Jan 31, 2023
@RobbieTheWagner RobbieTheWagner deleted the addon-v2 branch January 31, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants