-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree-shaking via only / except configuration is broken in v4 #1323
Comments
@jelhan you are correct that support was dropped for it. I believe tree shaking should be automatic with embroider and only use the things you import, but I could be wrong. |
That's only true if consuming app uses Embroider and opted in to |
That's possible, but that is the future, so I don't know if we need configs for this anymore in this addon. |
I think it's a maintainer decision. I see two options:
A third one would be restoring the functionality for apps not using Embroider. This is discussed here: embroider-build/embroider#1748 (comment) It would be still a breaking change introduced in v4 but affecting a smaller subset of apps using this addon. |
I think documenting the breaking change is probably the best way to go here. |
The tree-shaking via
only
andexcept
configuration options does not seem to work anymore in 4.0.0. I think it was dropped when converting the addon to v2 in #945.I assume this was done by accident as the feature is still documented:
ember-math-helpers/docs/docs/configuration.md
Lines 1 to 19 in f7c0446
This breaking change is also not listed in the changelog:
ember-math-helpers/CHANGELOG.md
Lines 6 to 24 in f7c0446
I noticed this when investigating if we can convert Ember Bootstrap to a v2 addon without dropping support for tree-shaking through configuration.
The text was updated successfully, but these errors were encountered: