Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Add support for dynamic viewport units for question component #225

Closed
Rllyyy opened this issue Dec 19, 2022 · 0 comments
Closed

[FEATURE REQ] Add support for dynamic viewport units for question component #225

Rllyyy opened this issue Dec 19, 2022 · 0 comments
Assignees
@Rllyyy
Labels
enhancement New feature or request

Comments

@Rllyyy
Copy link
Owner

Rllyyy commented Dec 19, 2022

With the release of Chrome 108 all major browsers now support dynamic viewport units (dvh).
Before this view heights were calculated without the address bar on mobile, which would hide if scrolling down.
The result was a lot of whitespace when the bar was hidden.
Browser support: https://caniuse.com/viewport-unit-variants
@Rllyyy Rllyyy added the enhancement New feature or request label Dec 19, 2022
@Rllyyy Rllyyy self-assigned this Dec 19, 2022
@Rllyyy Rllyyy mentioned this issue Dec 19, 2022
Closed
Rllyyy added a commit that referenced this issue Dec 20, 2022
@Rllyyy
📏Added support for dynamic viewport units in question (#225)+:bug:Fix…
fada6cc 
…ed overflow on mobile landscape (#226)+:hammer:Converted JavaScript files to TypeScript (#216)
@Rllyyy Rllyyy closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rllyyy Rllyyy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rllyyy