Flaky tests (#423)

* fix flaky tests * fix any keyword
Rllyyy · Dec 21, 2024 · b818033 · b818033
1 parent e42a88c
commit b818033
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/cypress.config.ts b/cypress.config.ts
@@ -10,9 +10,11 @@ export default defineConfig({
       });
     },
     baseUrl: "http://localhost:3000",
+    defaultBrowser: "chrome",
   },
 
   component: {
+    defaultBrowser: "chrome",
     devServer: {
       framework: "react",
       bundler: "vite",
@@ -40,9 +42,7 @@ export default defineConfig({
   },
 });
 
-// Fuck cypress and their slow ass adoptation
-
-function deleteFolder(folderName) {
+function deleteFolder(folderName: string) {
   return new Promise((resolve, reject) => {
     if (existsSync(folderName)) {
       rmdir(folderName, { maxRetries: 10, recursive: true }, (err) => {

diff --git a/src/components/QuestionEditor/QuestionEditor.cy.tsx b/src/components/QuestionEditor/QuestionEditor.cy.tsx
@@ -129,7 +129,7 @@ describe("QuestionEditor.cy.js", () => {
     cy.contains("Please select a Question Type").should("not.exist");
   });
 
-  it("should grow the textarea", { scrollBehavior: false, viewportHeight: 500, viewportWidth: 480 }, () => {
+  it("should grow the textarea", { scrollBehavior: false, viewportHeight: 500, viewportWidth: 480, retries: 5 }, () => {
     cy.get("textarea[name='title']")
       .type("The title for this question should wrap to the next line", { delay: 1 })
       .invoke("outerHeight")

diff --git a/src/components/QuestionList/QuestionList.cy.tsx b/src/components/QuestionList/QuestionList.cy.tsx
@@ -50,7 +50,7 @@ describe("QuestionList", () => {
 });
 
 describe("QuestionList - Drag and Drop", { viewportWidth: 780 }, () => {
-  it("should move a question", () => {
+  it("should move a question", { retries: 5 }, () => {
     cy.fixtureToLocalStorage("repeatio-module-cypress_1.json");
     cy.mount(<QuestionListWithRouter moduleID='cypress_1' />);
 
@@ -59,6 +59,7 @@ describe("QuestionList - Drag and Drop", { viewportWidth: 780 }, () => {
       .realMouseDown({ button: "left", position: "center" })
       .realMouseMove(0, 150, { position: "center" })
       .realMouseUp({ position: "center" })
+      .wait(500)
       .then(() => {
         cy.get("span[cy-data='id']").should(($spans) => {
           const idValues = $spans.toArray().map((span) => span.textContent);
@@ -67,9 +68,7 @@ describe("QuestionList - Drag and Drop", { viewportWidth: 780 }, () => {
       });
 
     // Assert that the third question was the first question
-
     cy.get("div[cy-data='question']").eq(2).find("span[cy-data='id']").should("have.text", "qID-1");
-    cy.wait(500);
   });
 
   it("should update the localStorage after drag'n'drop", () => {