Fix for Reusable request bodies are not handled correctly #2747 #5196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All setting of the client access modifier (RicoSuter#4820)
Contributor
Author
|
i just saw that there is already a pull request #4747 .. it looks almost the same as mine.. not sure why that one is not approved.. but maybe my pullrequest is not needed. |
This was referenced Sep 19, 2025
Merged
Closed
Closed
Closed
This was referenced Sep 26, 2025
Closed
This was referenced Sep 30, 2025
Closed
Closed
Closed
This was referenced Oct 7, 2025
Closed
Closed
This was referenced Oct 14, 2025
Closed
Closed
This was referenced Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating a (csharp) client did not type the body parameter if the body contains a $ref to a reusable request body.
This pullrequest fixes the bug #2747 "Reusable request bodies are not handled correctly".
sidenote; the class name of the typed body will saidly be called "Body" (or with a number if there are multiple bodyies).. can't find a way to fix that without changing the NJsonSchema project. (out of scope for now).