Bump NSwag.AspNetCore from 14.4.0 to 14.6.1

[dependabot]

Updated NSwag.AspNetCore from 14.4.0 to 14.6.1.

Release notes

Sourced from NSwag.AspNetCore's releases.

14.6.1

What's Changed

• Fix binary operation result type generation for AspNetCore CSharp by @​xamele0n in Fix binary operation result type generation for AspNetCore CSharp RicoSuter/NSwag#5255
• Update NJsonSchema to v11.5.1 by @​RicoSuter in Update NJsonSchema to v11.5.1 RicoSuter/NSwag#5279
  • https://github.com/RicoSuter/NJsonSchema/releases/tag/v11.5.1
• fix: Support web host (legacy) in ServiceProviderResolver by @​RicoSuter in fix: Support web host (legacy) in ServiceProviderResolver RicoSuter/NSwag#5278

New Contributors

• @​xamele0n made their first contribution in Fix binary operation result type generation for AspNetCore CSharp RicoSuter/NSwag#5255

Full Changelog: RicoSuter/NSwag@v14.6.0...v14.6.1

14.6.0

What's Changed

• Update NJS v11.5.0, breaking: minimum TypeScript output version is now 4.3 by @​RicoSuter in feature: Update NJS v11.5.0, require TypeScript >= 4.3 RicoSuter/NSwag#5268
• Add .NET 10 support by @​RicoSuter in Add .NET 10 support RicoSuter/NSwag#5271
• Fix generating typescript fetch client interfaces when useAbortSignal is false by @​htuomola in Fix generating typescript fetch client interfaces when useAbortSignal is false RicoSuter/NSwag#5243
• Add test coverage for some APIs by @​lahma in Add test coverage for some APIs RicoSuter/NSwag#5244
• Issue-5239 - Adding K6 template to TypeScript Code Generator by @​jsclifford in Issue-5239 - Adding K6 template to TypeScript Code Generator RicoSuter/NSwag#5240
• Fix NPM CLI argument handling by @​lahma in Fix NPM CLI argument handling RicoSuter/NSwag#5245
• #​5250 - K6 template for Typescript has errors when void is return type by @​jsclifford in #5250 - K6 template for Typescript has errors when void is return type RicoSuter/NSwag#5251
• Add option to generate code only for selected operation IDs by @​amayouf in Add option to generate code only for selected operation IDs RicoSuter/NSwag#5248
• Add credentials and mode attributes to fetch template generation by @​etriebe in Add credentials and mode attributes to fetch template generation RicoSuter/NSwag#5235
• Fix for Reusable request bodies are not handled correctly #​2747 by @​Doomic in Fix for Reusable request bodies are not handled correctly #2747 RicoSuter/NSwag#5196
• Refactor: Inline NConsole with fixes by @​RicoSuter in feature: Inline NConsole with fixes RicoSuter/NSwag#5272

New Contributors

• @​htuomola made their first contribution in Fix generating typescript fetch client interfaces when useAbortSignal is false RicoSuter/NSwag#5243
• @​jsclifford made their first contribution in Issue-5239 - Adding K6 template to TypeScript Code Generator RicoSuter/NSwag#5240
• @​amayouf made their first contribution in Add option to generate code only for selected operation IDs RicoSuter/NSwag#5248
• @​etriebe made their first contribution in Add credentials and mode attributes to fetch template generation RicoSuter/NSwag#5235

Full Changelog: RicoSuter/NSwag@v14.5.0...v14.6.0

14.5.0

What's Changed

• Better support for reading yaml from a stream by @​simonthum in Better support for reading yaml from a stream RicoSuter/NSwag#5170
• #​4821 Cleanup packages to use those provided by framework by @​thompson-tomo in #4821 Cleanup packages to use those provided by framework RicoSuter/NSwag#4831
• Set GH actions target .NET SDK to 9.0.204 by @​lahma in Set GH actions target .NET SDK to 9.0.204 RicoSuter/NSwag#5172
• Better support for reading yaml from a stream (part two) by @​simonthum in Better support for reading yaml from a stream (part two) RicoSuter/NSwag#5171
• Avoid multiple enumeration of array typed path parameters by @​Khyalis in Avoid multiple enumeration of array typed path parameters RicoSuter/NSwag#5149
• Restores all disabled compiler warnings. 649 and 8765 were missing. by @​carlbjorknas in Restores all disabled compiler warnings. 649 and 8765 were missing. RicoSuter/NSwag#4962
• Fix to explode array parameters implicitly when SchemaType is OpenAPI 3.0 by @​Phoosha in Fix to explode array parameters implicitly when SchemaType is OpenAPI 3.0 RicoSuter/NSwag#5176
• Adding cancellationToken to all calls to ReadAsStringAsync() and ReadAsStreamAsync() by @​arshrp in Adding cancellationToken to all calls to ReadAsStringAsync() and ReadAsStreamAsync() RicoSuter/NSwag#5187
• Remove requirement for specific NET SDK in GH Actions by @​lahma in Remove requirement for specific NET SDK in GH Actions RicoSuter/NSwag#5188
• Adjusted cancellationToken to work for all NSwag supported frameworks by @​arshrp in Adjusted cancellationToken to work for all NSwag supported frameworks RicoSuter/NSwag#5190
• Allow setting of the client interface access modifier based on the model access modifier by @​pbolduc in Allow setting of the client interface access modifier based on the model access modifier RicoSuter/NSwag#4820
• Prioritize wildcard over json over first entry for accept content-type by @​mdi1984 in Prioritize wildcard over json over first entry for accept content-type RicoSuter/NSwag#5198
• Reduce interface dispatch to improve performance by @​lahma in Reduce interface dispatch to improve performance RicoSuter/NSwag#5199
• Surface ExtensionData in CSharpControllerTemplateModel by @​hirudan in Surface ExtensionData in CSharpControllerTemplateModel RicoSuter/NSwag#5204
• Expose the UseRequiredKeyword on CSharpClientGeneratorSettings for CSharp client generator by @​r-englund in Expose the UseRequiredKeyword on CSharpClientGeneratorSettings for CSharp client generator RicoSuter/NSwag#5205
• Fix to expose an optional param for AbortSignal (for axios) / CancelToken (for fetch) when GenerateClientInterfaces = true by @​tomvdk in Fix to expose an optional param for AbortSignal (for axios) / CancelToken (for fetch) when GenerateClientInterfaces = true RicoSuter/NSwag#5202
• Sort client operation responses by status code by @​lahma in Sort client operation responses by status code RicoSuter/NSwag#5206
• TSC UpdateUseDtoClassAndDataConversionCodeProperties cleanup by @​lahma in TSC UpdateUseDtoClassAndDataConversionCodeProperties cleanup RicoSuter/NSwag#5212
• Update Microsoft.AspNetCore.* references to target 2.3.0 by @​lahma in Update Microsoft.AspNetCore.* references to target 2.3.0 RicoSuter/NSwag#5214
• Convert to using Central Package Management by @​lahma in Convert to using Central Package Management RicoSuter/NSwag#5217
• Convert NSwagStudio setup to use WiX 6 by @​lahma in Convert NSwagStudio setup to use WiX 6 RicoSuter/NSwag#5218
• Add support for TypeScript compilation testing by @​lahma in Add support for TypeScript compilation testing RicoSuter/NSwag#5219
• Replace TypeScript string contain asserts with Verify tests by @​lahma in Replace TypeScript string contain asserts with Verify tests RicoSuter/NSwag#5220
• Replace C# string contain asserts with Verify tests by @​lahma in Replace C# string contain asserts with Verify tests RicoSuter/NSwag#5221
• Remove deprecated tslint suppression by @​CaringDev in Remove deprecated tslint suppression RicoSuter/NSwag#5020
• Fix empty enumerable parameter handling in C# client by @​lahma in Fix empty enumerable parameter handling in C# client RicoSuter/NSwag#5222
• Fix: C# Code Generation generates method with return default(void) by @​nzeemin in Fix: C# Code Generation generates method with return default(void) RicoSuter/NSwag#4826
• Optimize DefaultParameterNameGenerator and add some more char cleanup by @​lahma in Optimize DefaultParameterNameGenerator and add some more char cleanup RicoSuter/NSwag#5223
• Convert more tests to use verify by @​lahma in Convert more tests to use verify RicoSuter/NSwag#5224
• Convert to xUnit v3 by @​lahma in Convert to xUnit v3 RicoSuter/NSwag#5225
• Ensure operation names start with alphanumeric character by @​lahma in Ensure operation names start with alphanumeric character RicoSuter/NSwag#5227
• Change GenerateSampleSpecificationTests to auto verify mode by @​lahma in Change GenerateSampleSpecificationTests to auto verify mode RicoSuter/NSwag#5228
• Show DisplayName for conflicting actions by @​Saibamen in Show DisplayName for conflicting actions RicoSuter/NSwag#5057
• Fix: When generated TS class name is "Error", it is conflicting with TS Error class by @​doruk-info in Fix: When generated TS class name is "Error", it is conflicting with TS Error class RicoSuter/NSwag#5032
• Update NJsonSchema to 11.4.0, update testsuite to reflect a change in class name generation by @​WolfgangHG in Update NJsonSchema to 11.4.0, update testsuite to reflect a change in class name generation RicoSuter/NSwag#5177
• Improve nswag.js parameter handling by @​KaterSchnurz in Improve nswag.js parameter handling RicoSuter/NSwag#5232
• Use TypeScript 4.3 as default testing version by @​lahma in Use TypeScript 4.3 as default testing version RicoSuter/NSwag#5234
• v14.5.0 by @​RicoSuter in v14.5.0 RicoSuter/NSwag#5236

New Contributors

• @​simonthum made their first contribution in Better support for reading yaml from a stream RicoSuter/NSwag#5170
• @​thompson-tomo made their first contribution in #4821 Cleanup packages to use those provided by framework RicoSuter/NSwag#4831
• @​Khyalis made their first contribution in Avoid multiple enumeration of array typed path parameters RicoSuter/NSwag#5149
• @​carlbjorknas made their first contribution in Restores all disabled compiler warnings. 649 and 8765 were missing. RicoSuter/NSwag#4962
• @​Phoosha made their first contribution in Fix to explode array parameters implicitly when SchemaType is OpenAPI 3.0 RicoSuter/NSwag#5176
• @​arshrp made their first contribution in Adding cancellationToken to all calls to ReadAsStringAsync() and ReadAsStreamAsync() RicoSuter/NSwag#5187
• @​pbolduc made their first contribution in Allow setting of the client interface access modifier based on the model access modifier RicoSuter/NSwag#4820
  ... (truncated)

Commits viewable in compare view.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[github-actions]

Ollama Code Review for AspNetCoreSerilog/AspNetCoreSerilog.csproj:\n\nCode Review and Suggestions

The provided code snippet is a C# project file (.csproj) for a .NET Web API application. Overall, the code looks clean and well-structured. However, here are some suggestions for improvement:

1. Consistent indentation: The indentation in the ItemGroup section is inconsistent. It's recommended to use 4 spaces for each level of indentation.

2. Package version comments: While it's good that you're including package versions, it would be helpful to include a comment explaining why these specific versions were chosen.

3. Target Framework explanation: The target framework net8.0 is specified in the PropertyGroup. However, it might be beneficial to add a brief explanation of why this version was chosen for your application.

4. UserSecretsId security: Storing sensitive data like API keys or secrets directly in the project file can pose security risks if the file becomes accessible to unauthorized parties. Consider using environment variables or a secure storage mechanism instead.

5. DockerDefaultTargetOS explanation: The DockerDefaultTargetOS property specifies the default operating system for Docker images. It might be helpful to add a brief comment explaining why this version was chosen for your application.

6. LangVersion comments: Include a comment explaining why you're using the default language version, as it might affect compilation and runtime behavior.

7. Consistent naming conventions: The property names in the PropertyGroup section follow the PascalCase convention. However, some package references use camelCase (e.g., Microsoft.AspNetCore.Authentication). Consistency is key to maintainability.

8. Package reference organization: Consider grouping related packages together for easier maintenance and updates.

Here's an updated version of the code with these suggestions applied:

<Project Sdk="Microsoft.NET.Sdk.Web">
    <PropertyGroup>
        <!-- Target Framework for the application -->
        <TargetFramework>net8.0</TargetFramework>
        
        <!-- UserSecretsId security: Use environment variables or secure storage instead -->
        <!-- <UserSecretsId>9d750d08-73ae-4876-83cc-4aad393eef18</UserSecretsId> -->

        <!-- Default Docker operating system for images -->
        <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>

        <!-- Language version for compilation and runtime behavior -->
        <!-- <LangVersion>default</LangVersion> -->
    </PropertyGroup>

    <ItemGroup>
        <!-- Microsoft.AspNetCore.Authentication package references -->
        <PackageReference Include="Microsoft.AspNetCore.Authentication" Version="2.3.0">
            <!-- Explanation: This package is used for authentication in the application. -->
        </PackageReference>
        
        <!-- Microsoft.AspNetCore.Authentication.JwtBearer package reference -->
        <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.18">
            <!-- Explanation: This package is used to implement JWT bearer authentication. -->
        </PackageReference>

        <!-- NSwag.AspNetCore package references -->
        <PackageReference Include="NSwag.AspNetCore" Version="14.6.1">
            <!-- Explanation: This package is used for Swagger documentation and API client generation. -->
        </PackageReference>
        
        <!-- Serilog.AspNetCore package reference -->
        <PackageReference Include="Serilog.AspNetCore" Version="9.0.0">
            <!-- Explanation: This package is used for logging and logging enrichment in the application. -->
        </PackageReference>

        <!-- Serilog.Enrichers.Environment package reference -->
        <PackageReference Include="Serilog.Enrichers.Environment" Version="3.0.1">
            <!-- Explanation: This package is used to enrich log messages with environment information. -->
        </PackageReference>
        
        <!-- Serilog.Enrichers.Thread package reference -->
        <PackageReference Include="Serilog.Enrichers.Thread" Version="4.0.0">
            <!-- Explanation: This package is used to enrich log messages with thread information. -->
        </PackageReference>
    </ItemGroup>
</Project>

Readability and Maintainability Improvements

1. Consistent naming conventions: Use consistent PascalCase or camelCase throughout the project.

2. Comments and explanations: Include comments and explanations for package versions, target frameworks, and other settings to make it easier for others (or yourself in the future) to understand the application's requirements.

3. Group related packages together: Organize package references into categories (e.g., authentication, logging, Swagger documentation) for better maintainability.

4. Use consistent indentation: Use 4 spaces for each level of indentation throughout the project.

5. Consider automated dependency management tools: Look into using tools like NuGet or package managers to automate dependency updates and reduce maintenance efforts.

By applying these suggestions, you can improve the readability, maintainability, and overall quality of your .NET Web API application's configuration file.

[github-actions]

Ollama Code Review for AspNetCoreSerilog/AspNetCoreSerilog.csproj:\n\n# Review and Suggestions

The provided code snippet appears to be a .csproj file for a .NET 8.0 web application, likely targeting ASP.NET Core.

Improvements and Suggestions:

1. Consistent Indentation: The indentation is inconsistent throughout the file. It's recommended to use 4 spaces for indentation consistently.

2. Package Grouping: Instead of listing all packages under <ItemGroup>, consider grouping related packages together for better readability. For example, you could separate Authentication-related packages from other dependencies.

3. Version Management: Consider using a NuGet package manager like dotnet nuget or dotnet tool to manage your project's dependencies and keep them up-to-date.

4. Target Framework Versioning: Make sure the target framework version is not too low, as it might limit the compatibility with newer frameworks and libraries.

5. Dependency Management: Consider using a tool like pipewire or dotnet tool to manage your project's dependencies, which can help reduce version conflicts and improve overall maintainability.

6. Code Formatting: Use a consistent code formatting style throughout the file. This includes alignment of properties, spacing between elements, and line length limits.

7. Comments: Comments are essential for explaining complex logic or unfamiliar sections of code. However, in this case, there are no comments to add.

8. Error Handling: Always include proper error handling mechanisms in your code to prevent crashes and ensure a smooth user experience.

Refactored Code:

<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <!-- Target Framework Version -->
    <TargetFramework>net8.0</TargetFramework>

    <!-- UserSecrets ID -->
    <UserSecretsId>9d750d08-73ae-4876-83cc-4aad393eef18</UserSecretsId>

    <!-- Docker Default Target OS -->
    <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>

    <!-- Language Version -->
    <LangVersion>default</LangVersion>
  </PropertyGroup>

  <!-- Package References Grouping -->
  <ItemGroup>
    <!-- Authentication Packages -->
    <PackageReference Include="Microsoft.AspNetCore.Authentication" Version="2.3.0" />
    <PackageReference Include="Microsoft.AspNetCore.Authentication.JwtBearer" Version="8.0.20" />

    <!-- NSwag and Serilog Packages -->
    <PackageReference Include="NSwag.AspNetCore" Version="14.6.1" />
    <PackageReference Include="Serilog.AspNetCore" Version="9.0.0" />
    <PackageReference Include="Serilog.Enrichers.Environment" Version="3.0.1" />
    <PackageReference Include="Serilog.Enrichers.Thread" Version="4.0.0" />
  </ItemGroup>
</Project>

Final Thoughts:

Always keep your project's dependencies up-to-date and consider using a tool like pipewire or dotnet tool to manage them, which can help reduce version conflicts and improve overall maintainability.

Make sure to follow consistent code formatting styles throughout the file for better readability.