Replace DotLiquid with Fluid

[lahma]

Still work in progress, uses preview feed for NJsonSchema.

• update templates to follow strict liquid syntax
• net461 minimum full framework
• netstandard 1.3 removed, netstandard 2.0 is minimum when generating code using templates

[sebastienros]

FYI EscapeDataString has been removed in 6.0-rc2. I see it's used in the resulting code.

[RicoSuter]

@sebastienros and what's the replacement for it?

[lahma]

@RicoSuter thanks for helping out here, how's it looking from your perspective? Seems that the libs in VCS didn't restore correctly on ADO build

[RicoSuter]

There are some line breaks which we should remove:

NJS:

NSwag:

Couldnt find where these are yet...
Otherwise it looks good so far...

Seems that the libs in VCS didn't restore correctly on ADO build

Yes, the build pipeline needs to be improved so that we only have one (ideally ADO) - currently we have two: Appvayor (Full) and ADO (partial, couldnt get full to run there)... Hopefully the nuke build improves/simplifies that... Also a problem for that is that there is a lot of legacy support (full .net etc.).

[lahma]

I think I can check these these extra line breaks this weekend the latest unless you find out something before.

I would be a bit cautious with ADO though, MS has shifted interest to GH actions (I'd even argue they are sunsetting ADO) and they are far faster than ADO by what I have observed. GH actions also integrate a lot better with GH PR status UI.

Let me know if you would like me to add GH actions workflows to NUKE PR.

[sebastienros]

Actually it might be another one that is obsoleted: EscapeUriString dotnet/runtime#41501

[RicoSuter]

Let me know if you would like me to add GH actions workflows to NUKE PR.

It makes sense to improve the CI and GH actions are fine for me.
We should ensure that you can run the full build easily locally and the CI build should produce all artifacts...
What about the CD pipeline? ie pushing the nuget and npm packages and releasing the NSwagStudio MSI (maybe we use a regular GitHub release for that)?

[sebastienros]

There are nupkg files in the PR

[lahma]

It makes sense to improve the CI and GH actions are fine for me. We should ensure that you can run the full build easily locally and the CI build should produce all artifacts... What about the CD pipeline? ie pushing the nuget and npm packages and releasing the NSwagStudio MSI (maybe we use a regular GitHub release for that)?

We can do these, but can you describe how it currently works, is AppVeyor doing something all is everything manual? I saw there's 04_Publish.bat which only does NPM publish - is it used in automation or your personal tool?

I think NUKE could do following steps in Publish target:

• triggered by new GH actions decription for tag happening with prefix v on master, e.g. v14.5.2
• if there's a tag and we are on main/master - continue, otherwise skip publish
• build, test, pack
• create GitHub release with name taken from the tag, e.g. 14.5.2 via github API (requires API key)
• upload .msi and .zip to new release
• do dotnet nuget push to nuget.org (requires NuGet API key)
• push nswagstudio nupkg to chocolatey - I've never done this, requires Yet Another API Key?
• do NPM publish (requires NPM API key)

So I could make base setup for you as a PR, but you basically are only one to complete the challenge with access to keys etc. Probably will make sense to do "beta" releases.

[sebastienros]

I think NUKE could do ...

Nothing too

[sebastienros]

I just lost a valuable contributor ;)

[lahma]

What a emotional moment, build passes, tests are green.