Merged
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
added 2 commits
August 28, 2020 15:04
MihaZupan
approved these changes
Aug 28, 2020
jkotas
reviewed
Aug 28, 2020
| internal const string CodeBaseDiagId = "SYSLIB0012"; | ||
|
|
||
| internal const string EscapeUriStringMessage = "Uri.EscapeUriString can corrupt the Uri string in some cases. Consider using Uri.EscapeDataString instead."; | ||
| internal const string EscapeUriStringDiagId = "SYSLIB0013"; |
added 3 commits
August 28, 2020 16:46
am11
reviewed
Aug 29, 2020
Co-authored-by: Adeel Mujahid <adeelbm@outlook.com>
jkotas
approved these changes
Sep 1, 2020
Member
|
@aik-jahoda Can you add this obsoletion to https://github.com/dotnet/runtime/blob/master/docs/project/list-of-obsoletions.md please? |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of our Uri.EscapeUriString obsoletion effort #31387.