Raise Python minimum version to 3.7 #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, this package is set to require Python >= 3.6. I propose bumping to Python >= 3.7 since Python 3.6 is no longer receiving security updates. **Be aware this will almost certainly break things for some users.** Ubuntu 18.04 ships with Python 3.6 so a user would have to use pyenv, virtualenv, a different PPA, or some other method for installing Python or use a Docker container to run this code. Ubuntu 18.04 is still relatively widely used. Ubuntu 20.04 ships with Python 3.8. I have created a prototype Dockerfile in a fork that containerizes this application so that approach seems reasonable and does work. It is also fairly straightforward to install pyenv and that is how I've always run this package. I suggest this as a good time for an upgrade because the API for ttps://bootstrap.pypa.io/get-pip.py just deprecated Python 3.6.
rsinnet
force-pushed
the
user/rsinnet/python3.7
branch
from
7e689d6
to
434c809
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise Python minimum version to 3.7
Currently, this package is set to require Python >= 3.6. I propose
bumping to Python >= 3.7 since Python 3.6 is no longer receiving
security updates.
Be aware this will almost certainly break things for some users.
Ubuntu 18.04 ships with Python 3.6 so a user would have to use pyenv,
virtualenv, a different PPA, or some other method for installing Python
or use a Docker container to run this code. Ubuntu 18.04 is still
relatively widely used. Ubuntu 20.04 ships with Python 3.8.
I have created a prototype Dockerfile in a fork that containerizes this
application so that approach seems reasonable and does work. It is also
fairly straightforward to install pyenv and that is how I've always run
this package.
I suggest this as a good time for an upgrade because the API for
ttps://bootstrap.pypa.io/get-pip.py just deprecated Python 3.6.