Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add radioactive chunk miche and make AI to use and omit radioactive chunks #5867

Merged
merged 10 commits into from
Feb 5, 2025

Conversation

Patryk26g
Copy link
Contributor

@Patryk26g Patryk26g commented Jan 31, 2025

Brief Description of What This PR Does

  • Adds radioactive chunk miche. The miche fills only after the nucleus is developed just as expected.
  • AI omits the radioactive chunks when it starts taking damage
  • AI with melanosomes stays near the chunk to produce ATP

Here's the link to the test save where there are some species that have melanosomes: https://dev.revolutionarygamesstudio.com/files/Public/Testing%20Resources/Saves/Radioactive%20Chunk%20AI%20Test%20Save.thrivesave

Related Issues

Closes #5857
Closes #5855
Closes #5856

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@Patryk26g Patryk26g added this to the Release 0.8.1 milestone Jan 31, 2025
@GameDungeon
Copy link
Contributor

Didn't test, but the code all checks out Auto-Evo wise

@Patryk26g Patryk26g changed the title Add radioactive chunk miche Add radioactive chunk miche and make AI omit radioactive chunks Feb 1, 2025
@Patryk26g Patryk26g changed the title Add radioactive chunk miche and make AI omit radioactive chunks Add radioactive chunk miche and make AI to use and omit radioactive chunks Feb 1, 2025
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is already in very good shape but I had a few small technical comments on the code (I haven't playtested).

Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes seem fine to me. I doubt there's anyone who would do playtesting even if this was left open for longer so I'll just merge this.

@hhyyrylainen
Copy link
Member

Actually this needs merge conflicts to be resolved before this can be merged.

# Conflicts:
#	src/microbe_stage/systems/MicrobeAISystem.cs
@hhyyrylainen hhyyrylainen merged commit 06f366e into master Feb 5, 2025
4 checks passed
@hhyyrylainen hhyyrylainen deleted the feature_5857_radioactiveChunkMiche branch February 5, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
3 participants